Skip to content

BUG: BooleanArray.value_counts dropna #30824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2020
Merged

BUG: BooleanArray.value_counts dropna #30824

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d1abac
BUG: BooleanArray.value_counts dropna
TomAugspurger Jan 8, 2020
b3796a5
Merge remote-tracking branch 'upstream/master' into 30685-value_counts
TomAugspurger Jan 9, 2020
604f170
fixup
TomAugspurger Jan 9, 2020
12cfbeb
remove unused numpy_dtype
TomAugspurger Jan 9, 2020
67c0c06
doc fixup
TomAugspurger Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused numpy_dtype
  • Loading branch information
@TomAugspurger
TomAugspurger committed Jan 9, 2020
commit 12cfbebb86c73170bc43d7df943e4cea7a7d2565
5 changes: 0 additions & 5 deletions pandas/core/arrays/boolean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ def na_value(self) -> "Scalar":
def type(self) -> Type:
return np.bool_

@property
def numpy_dtype(self):
""" Return an instance of our numpy dtype """
return np.dtype(self.type)

@property
def kind(self) -> str:
return "b"
Expand Down