ENH: Implement PeriodIndex.intersection without object-dtype cast #30666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Jan 3, 2020
For the length=1000 index in the benchmark we take a hit of about 37%. When I change the benchmark to be length=10**5 it is no change. |
jreback
approved these changes
Jan 4, 2020
| @@ -799,6 +803,30 @@ def _wrap_setop_result(self, other, result): | |||
| result.name = name | |||
| return result | |||
|
|
|||
| def intersection(self, other, sort=False): | |||
| self._assert_can_do_setop(other) | ||
| res_name = get_op_result_name(self, other) | ||
| other = ensure_index(other) | ||
|
|
There was a problem hiding this comment.
can this code be shared with superclasses?
There was a problem hiding this comment.
i think so, its going to be a few steps before we get there
jreback
added
Index
interesting, i though this would be faster. ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodIndex._simple_new is not as simple as it should be. In order to get it to have the appropriate signature we need to implement some of the set methods correctly. This is the first of those.