Skip to content

BLD: catch missing cython instead of tempita NameError #30498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019
Merged

BLD: catch missing cython instead of tempita NameError #30498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a27b725
BLD: add check to prevent tempita name error, clsoes #28836
jbrockmendel Dec 27, 2019
50df3de
Merge branch 'master' of https://github.com/pandas-dev/pandas into bl…
jbrockmendel Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,10 @@ def maybe_cythonize(extensions, *args, **kwargs):
# See https://github.com/cython/cython/issues/1495
return extensions

elif not cython:
# GH#28836 raise a helfpul error message
raise RuntimeError("Cannot cythonize without Cython installed.")

numpy_incl = pkg_resources.resource_filename("numpy", "core/include")
# TODO: Is this really necessary here?
for ext in extensions:
Expand Down