API: Rename BaseGrouper.recons_codes to BaseGrouper.reconstructed_codes #29471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
WillAyd
approved these changes
Nov 7, 2019
|
this needs to coordinate with #28634 (so may need to rebase here once that is merged) |
|
The other PR is from a first time contributor that's been at it for a month and a half, so I think let's merge that first and rebase here to keep things moving |
|
@topper-123 if you can rebase; might need to type the added method |
topper-123
force-pushed
the
typ_groupby
branch
from
cea09ca to
7461d48
Compare
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
BaseGrouper.recons_codestoBaseGrouper.reconstructed_codes. This is an internal attribute, so ok to rename.Also adds some typing.