Skip to content

API: Use object dtype for empty Series #29405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2019
Merged

API: Use object dtype for empty Series #29405

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c8c67d
added FutureWarning to empty Series without dtype and adjusted the te…
SaturnFromTitan Nov 24, 2019
4ba36b4
took care of review comments
Dec 2, 2019
8db3cc4
typing of helper functions
SaturnFromTitan Dec 5, 2019
67e00ff
fix imports
SaturnFromTitan Dec 5, 2019
ce80f48
Merge branch 'master' into use-object-dtype-for-empty-series
SaturnFromTitan Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into use-object-dtype-for-empty-series
  • Loading branch information
@SaturnFromTitan
SaturnFromTitan committed Dec 5, 2019
commit ce80f485ed207de63d00d93f07c0165af56f63c3
11 changes: 3 additions & 8 deletions pandas/tests/plotting/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,9 @@ def test_get_accessor_args():
with pytest.raises(TypeError, match=msg):
func(backend_name="", data=[], args=[], kwargs={})

with tm.assert_produces_warning(FutureWarning, check_stacklevel=False):
x, y, kind, kwargs = func(
backend_name="", data=Series(dtype=object), args=["line", None], kwargs={}
)
assert x is None
assert y is None
assert kind == "line"
assert kwargs == {"ax": None}
msg = "should not be called with positional arguments"
with pytest.raises(TypeError, match=msg):
func(backend_name="", data=Series(dtype=object), args=["line", None], kwargs={})

x, y, kind, kwargs = func(
backend_name="",
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.