Fix pipe docs #29368
Merged
Fix pipe docs #29368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Unsure why the code coverage has dramatically reduced.. |
WillAyd
requested changes
Nov 3, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
Want to avoid using lambdas where possible
| """ | ||
| Chicago, IL -> Chicago for city_name column | ||
| """ | ||
| df['city_name'] = df['city_and_code'].apply(lambda x: x.split(', ')[0]) |
Member
There was a problem hiding this comment.
Suggested change
| df['city_name'] = df['city_and_code'].apply(lambda x: x.split(', ')[0]) | |
| df['city_name'] = df['city_and_code'].str.split(",").str.get(0) |
| Chicago -> Chicago-US for city_name column | ||
| """ | ||
| col = 'city_name' | ||
| df['city_and_country'] = df[col].apply(lambda x: f'{x}-{country_name}') |
Member
There was a problem hiding this comment.
Suggested change
| df['city_and_country'] = df[col].apply(lambda x: f'{x}-{country_name}') | |
| df['city_and_country'] = df[col] + "-USA" |
Member
Author
|
Thanks for the comments @WillAyd totally agree - updated |
WillAyd
approved these changes
Nov 4, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
lgtm @datapythonista care to take a look here?
Member
|
Thanks @alimcmaster1 |
Member
Author
|
Thanks @WillAyd |
Member
|
Sorry I couldn't check this before. Looks great, good job @alimcmaster1. Happy to see this finally improved. |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the image below which highlights what i've done here
flake8-rst doc/source --filename=/getting_started/basics.rstruns cleancc. @datapythonista to review