Skip to content

Multiindex recurse error fix #29260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 1, 2020
Merged

Multiindex recurse error fix #29260

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
79a08d7
Merge pull request #1 from pandas-dev/master
endremborza Sep 19, 2019
9dda1ec
Merge remote-tracking branch 'upstream/master'
endremborza Oct 6, 2019
03529a9
Merge remote-tracking branch 'upstream/master'
endremborza Oct 28, 2019
d32222a
add test for multi join recursion error
endremborza Oct 28, 2019
02e2645
fix multi join recursion error
endremborza Oct 28, 2019
8bafd6b
black formatting
endremborza Oct 28, 2019
99aa8bd
add assertion to midx join test
endremborza Oct 31, 2019
a00e80f
style corrections
endremborza Oct 31, 2019
505d814
add assertion to midx join test
endremborza Oct 31, 2019
5f09a01
whatsnew entry for join
endremborza Oct 31, 2019
f22a665
exapnd multiindex test
endremborza Oct 31, 2019
66fb17d
whatsnew bugfix multiindex reshaping expand
endremborza Oct 31, 2019
12af280
Merge remote-tracking branch 'upstream/master'
endremborza Nov 20, 2019
b33cef8
Merge branch 'master' into multiindex-recurse-error-fix
endremborza Nov 20, 2019
18acc85
Merge branch 'master' into multiindex-recurse-error-fix
jreback Jan 1, 2020
733b1c6
clean tests
jreback Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew entry for join
  • Loading branch information
@endremborza
endremborza committed Oct 31, 2019
commit 5f09a0134cd22c31cc77676674e42651b63be56a
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,7 @@ Reshaping
- :func:`qcut` and :func:`cut` now handle boolean input (:issue:`20303`)
- Fix to ensure all int dtypes can be used in :func:`merge_asof` when using a tolerance value. Previously every non-int64 type would raise an erroneous ``MergeError`` (:issue:`28870`).
- Better error message in :func:`get_dummies` when `columns` isn't a list-like value (:issue:`28383`)
- Bug in :meth:`Index.join` that caused infinite recursion error for mismatched multiindex name orders (:issue:`25760`, :issue:`28956`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this more user-facing? I somehow doubt the test case in this PR is something users would do in actual code, so this seems to be hinting at addressing some other use case(s)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting a use case into the docs or expanding the tests?


Sparse
^^^^^^
Expand Down