Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Store metadata in an attrs dict #29062

Merged
merged 5 commits into from
Oct 22, 2019
Merged

REF: Store metadata in an attrs dict #29062

merged 5 commits into from
Oct 22, 2019

Commits on Oct 17, 2019

  1. REF: Store metadata in attrs dict 

    This aids in the implementation of
pandas-dev#28394. Over there, I'm having
issues with using `NDFrame.__finalize__` to copy attributes, in part
because getattribute on NDFrame is so complicated.

This simplifies this because we only need to look in NDFrame.attrs,
which is just a plain dictionary.

Aside from the addition of a public NDFrame.attrs dictionary, there
aren't any user-facing API changes.
    @TomAugspurger
    TomAugspurger committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    d1826bb View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. fixup Index.name

    @TomAugspurger
    TomAugspurger committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    e6183cd View commit details
    Browse the repository at this point in the history

  2. fixup name

    @TomAugspurger
    TomAugspurger committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    67a3263 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. added note on type checking

    @TomAugspurger
    TomAugspurger committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    d766c85 View commit details
    Browse the repository at this point in the history

  2. Added reference docs

    @TomAugspurger
    TomAugspurger committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    60fd202 View commit details
    Browse the repository at this point in the history