Skip to content

CLN: Fix mypy error in 'pandas/tests/computation/test_eval.py' #29007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2019
Merged

CLN: Fix mypy error in 'pandas/tests/computation/test_eval.py' #29007

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac8aa8
CLN: Fix mypy error in pandas/tests/computation/test_eval.py
immaxchen Oct 15, 2019
4ce45e0
Merge remote-tracking branch 'upstream/master' into fix-computation-t…
immaxchen Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CLN: Fix mypy error in pandas/tests/computation/test_eval.py 
Added explicit typing annotation for _parsers: Dict[str, Type[BaseExprVisitor]]
Also added some import for Dict, Type and BaseExprVisitor
  • Loading branch information
@immaxchen
immaxchen committed Oct 15, 2019
commit 8ac8aa8f16e7b555dadf9a5493cb07e43f454448
9 changes: 7 additions & 2 deletions pandas/tests/computation/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from functools import reduce
from itertools import product
import operator
from typing import Dict, Type
import warnings

import numpy as np
Expand All @@ -19,7 +20,11 @@
from pandas.core.computation.check import _NUMEXPR_VERSION
from pandas.core.computation.engines import NumExprClobberingError, _engines
import pandas.core.computation.expr as expr
from pandas.core.computation.expr import PandasExprVisitor, PythonExprVisitor
from pandas.core.computation.expr import (
BaseExprVisitor,
PandasExprVisitor,
PythonExprVisitor,
)
from pandas.core.computation.expressions import _NUMEXPR_INSTALLED, _USE_NUMEXPR
from pandas.core.computation.ops import (
_arith_ops_syms,
Expand Down Expand Up @@ -1884,7 +1889,7 @@ def test_invalid_parser():
"python": PythonExprVisitor,
"pytables": pytables.ExprVisitor,
"pandas": PandasExprVisitor,
}
} # type: Dict[str, Type[BaseExprVisitor]]


@pytest.mark.parametrize("engine", _engines)
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ ignore_errors=True
[mypy-pandas.tests.arrays.test_period]
ignore_errors=True

[mypy-pandas.tests.computation.test_eval]
ignore_errors=True

[mypy-pandas.tests.dtypes.test_common]
ignore_errors=True

Expand Down