Skip to content

BUG: Preserve key order when using loc on MultiIndex DataFrame #28933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 2, 2020
Merged

BUG: Preserve key order when using loc on MultiIndex DataFrame #28933

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2753c79
TST: Test for issue #22797
nrebena Sep 29, 2019
af5c678
BUG: sort MultiIndex DataFrame loc result
nrebena Oct 7, 2019
dd53a91
PERF: Skip sort of MultiIndex DataFrame loc result if not needed
nrebena Oct 8, 2019
97b952d
CLN: Some code simplification
nrebena Oct 23, 2019
3fa3c6d
CLN: Move code into separate function
nrebena Nov 18, 2019
8b5ec48
CLN: More typing and linting
nrebena Nov 18, 2019
fb33627
CLN: Improve readability and doc
nrebena Nov 18, 2019
2c6195f
DOC: Add a whatsnew
nrebena Nov 18, 2019
d911110
CLN: More typing for _reorder_indexer
nrebena Nov 20, 2019
81edea5
TST: Add more test cases to test_multiindex_loc_order
nrebena Nov 20, 2019
f1407f1
TST: move test_multiindex_loc_order to tests/test_multilevel.py
nrebena Jan 3, 2020
4c667a7
CLN: Move need_sort test in _reorder_indexer
nrebena Jan 3, 2020
ee89a33
TST: Test also for columns
nrebena Jan 3, 2020
c18d60d
FIX: Test need sort only work on lexsorted indexes
nrebena Jan 3, 2020
1717a14
Minor change in how to determined if sorting is needed
nrebena Jan 19, 2020
2ab8e30
PERF: Delete flag for sorting multiindex loc call.
nrebena Jan 19, 2020
edde717
TST: Parametrize tests
nrebena Jan 19, 2020
82e5109
DOC: Move whatsnew entry from v1.0.0 to v1.1.0
nrebena Jan 19, 2020
3367109
Revert "PERF: Delete flag for sorting multiindex loc call."
nrebena Jan 19, 2020
025d304
DOC: Add mini example to whatsnew
nrebena Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST: Add more test cases to test_multiindex_loc_order
  • Loading branch information
@nrebena
nrebena committed Feb 2, 2020
commit 81edea5705fad93f8f6339f1cc642c44d75de92b
16 changes: 16 additions & 0 deletions pandas/tests/indexes/multi/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,22 @@ def test_multiindex_loc_order():
exp_index = pd.MultiIndex.from_arrays([["b", "b", "a", "a"], [1, 2, 1, 2]])
tm.assert_index_equal(res.index, exp_index)

res = df.loc[["a", "b"], :]
exp_index = pd.MultiIndex.from_arrays([["a", "a", "b", "b"], [1, 2, 1, 2]])
tm.assert_index_equal(res.index, exp_index)

res = df.loc[(["a", "b"], [1, 2]), :]
exp_index = pd.MultiIndex.from_arrays([["a", "a", "b", "b"], [1, 2, 1, 2]])
tm.assert_index_equal(res.index, exp_index)

res = df.loc[(["a", "b"], [2, 1]), :]
exp_index = pd.MultiIndex.from_arrays([["a", "a", "b", "b"], [2, 1, 2, 1]])
tm.assert_index_equal(res.index, exp_index)

res = df.loc[(["b", "a"], [2, 1]), :]
exp_index = pd.MultiIndex.from_arrays([["b", "b", "a", "a"], [2, 1, 2, 1]])
tm.assert_index_equal(res.index, exp_index)

res = df.loc[(["b", "a"], [1, 2]), :]
exp_index = pd.MultiIndex.from_arrays([["b", "b", "a", "a"], [1, 2, 1, 2]])
tm.assert_index_equal(res.index, exp_index)