TST: Add test for categorical with str and tuples #28693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has2k1
force-pushed
the
mixed-type-categorical
branch
from
01c8f2d to
af67e31
Compare
|
This bug affects numpy versions 1.13.3 to 1.15.4. Versions greater than 1.16.0 are fine. However, since it was a regression in numpy (e.g. 1.11.0 is okay), I do not know if it will not show up again. The tests are failing for lower versions of numpy. |
|
To check for different versions of numpy, you need to skipif using the ``compat.numpy._np_version_under1p*` bools. |
has2k1
force-pushed
the
mixed-type-categorical
branch
from
af67e31 to
a3b6b3d
Compare
topper-123
requested changes
Oct 5, 2019
| # For NumPy <1.16, np.array(["", ("a",)]) raises | ||
| # ValueError: setting an array element with a sequence. | ||
| if _np_version_under1p16: | ||
| raise pytest.skip("Skipping for NumPy <1.16") |
There was a problem hiding this comment.
Better to decorate the test method with @pytest.mark.skipif( _np_version_under1p16, reason="Skipping for NumPy <1.16").
has2k1
force-pushed
the
mixed-type-categorical
branch
from
a3b6b3d to
2a77b7a
Compare
The bug is not present any more. closes pandas-dev#21416
has2k1
force-pushed
the
mixed-type-categorical
branch
from
2a77b7a to
09d58a9
Compare
topper-123
approved these changes
Oct 6, 2019
topper-123
added
Categorical
|
Thanks, @has2k1! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
The bug is not present any more. closes pandas-dev#21416
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
The bug is not present any more. closes pandas-dev#21416
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
The bug is not present any more. closes pandas-dev#21416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is not present any more.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff[ ] whatsnew entry