Skip to content

DEPR: Deprecate Index.set_value #28621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2019
Merged

DEPR: Deprecate Index.set_value #28621

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a41b72
DEPR: Deprecate Index.set_value
topper-123 Sep 25, 2019
e790a59
Add github issue to test
topper-123 Sep 26, 2019
b708d92
change according to comments
topper-123 Oct 2, 2019
2f422bb
fix quoting
jorisvandenbossche Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix quoting
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche authored Oct 3, 2019
commit 2f422bba3a5c332d86fbaac70979252fe945704b
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ Documentation Improvements
Deprecations
~~~~~~~~~~~~

- `Index.set_value` has been deprecated. For a given index ``idx``, array ``arr``,
- ``Index.set_value`` has been deprecated. For a given index ``idx``, array ``arr``,
value in ``idx`` of ``idx_val`` and a new value of ``val``, ``idx.set_value(arr, idx_val, val)``
is equivalent to ``arr[idx.get_loc(idx_val)] = val``, which should be used instead (:issue:`28621`).
-
Expand Down