Skip to content

ENH: Add argmax and argmin to ExtensionArray #27801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jul 8, 2020
Merged

ENH: Add argmax and argmin to ExtensionArray #27801

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8303674
Add argmax, max, argmin, min to EA
makbigc Aug 7, 2019
44838f7
Remove argmax, argmin, max, min from ArrowEA
makbigc Aug 9, 2019
8bc9573
Fix black error
makbigc Aug 9, 2019
bc69a4a
Add issue number to the test
makbigc Aug 10, 2019
4787c63
update
makbigc Aug 10, 2019
8bd82f5
merge for update
makbigc Dec 2, 2019
e84268b
Move the whatsnew entry to v1
makbigc Dec 2, 2019
f9c9fea
Add test for categorical
makbigc Dec 3, 2019
8b7585f
Add func doc and pre-check for zero length
makbigc Dec 4, 2019
41e8ce4
Add min and max to StringArray
makbigc Dec 4, 2019
20ca0a2
Add test for empty array
makbigc Dec 4, 2019
1aa7422
Resolve black format
makbigc Dec 5, 2019
f2b6958
merge again
makbigc Jan 18, 2020
7d81cc5
Fix test
makbigc Jan 18, 2020
d18c8bb
Fix lint error
makbigc Jan 18, 2020
3530a6a
Change the error message
makbigc Jan 19, 2020
8d8506a
Move the whatsnew entry from v1 to v1.1
makbigc Jan 19, 2020
e7e7c86
merge for update
makbigc Jan 22, 2020
10f9b27
merge for update
makbigc Jan 29, 2020
ccded0b
merge again
makbigc Feb 2, 2020
9aea8fe
merge for update
makbigc Feb 6, 2020
5636d2a
merge for update
makbigc Feb 7, 2020
4db39e0
merge again
makbigc Feb 14, 2020
2036b25
Refactor max and min
makbigc Feb 14, 2020
d81a8f8
merge again
makbigc Feb 25, 2020
58d46d0
merge for update
makbigc Feb 26, 2020
6b88790
Merge remote-tracking branch 'upstream/master' into enh-24382
jorisvandenbossche May 9, 2020
8cd7169
fixup merge
jorisvandenbossche May 9, 2020
810ac56
Remove min/max for now
jorisvandenbossche May 9, 2020
6b030aa
argmin/argmax implementation based on _values_for_argsort
jorisvandenbossche May 9, 2020
e5a6d8c
test clean-up + update docstring
jorisvandenbossche May 9, 2020
d7a49c1
Merge remote-tracking branch 'upstream/master' into enh-24382
jorisvandenbossche May 9, 2020
65e1e4c
simplify test_sparse override
jorisvandenbossche May 9, 2020
1b64e2f
Merge remote-tracking branch 'upstream/master' into enh-24382
jorisvandenbossche May 22, 2020
2cdf16b
Merge remote-tracking branch 'upstream/master' into enh-24382
jorisvandenbossche Jun 20, 2020
7c79f5c
Merge remote-tracking branch 'upstream/master' into enh-24382
jorisvandenbossche Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into enh-24382
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jun 20, 2020
commit 2cdf16bd65cb3714a483a97f7ba8059ea4c01eba

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.