Skip to content

CLN: short-circuit case in Block.replace #27768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 12, 2019
Merged

CLN: short-circuit case in Block.replace #27768

merged 8 commits into from
Aug 12, 2019

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 6, 2019

Running out of try/excepts to get rid of

@gfyoung gfyoung added the Clean label Aug 6, 2019
gfyoung
gfyoung reviewed Aug 6, 2019
View reviewed changes
@jreback
Copy link
Contributor

jreback commented Aug 6, 2019

any perf improvement? or just code clean

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Aug 6, 2019

any perf improvement? or just code clean

Only in corner cases

@gfyoung
Copy link
Member

gfyoung commented Aug 6, 2019

Only in corner cases

Worth including in benchmarks?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Aug 6, 2019

Worth including in benchmarks?

I'm not inclined to, no.

TomAugspurger
TomAugspurger approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gfyoung any other concerns?

gfyoung
gfyoung approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 12, 2019
@TomAugspurger TomAugspurger merged commit 01f90c1 into pandas-dev:master Aug 12, 2019
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 12, 2019

Thanks all.

@jbrockmendel jbrockmendel deleted the trys4 branch August 12, 2019 19:04
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
@jbrockmendel @quintusdias
CLN: short-circuit case in Block.replace (pandas-dev#27768)
6ec4cd9
This was referenced May 7, 2020
Closed
Closed
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request May 7, 2020
@simonjayhawkins
Revert "CLN: short-circuit case in Block.replace (pandas-dev#27768)"
65fe412 
This reverts commit 01f90c1.
@TomAugspurger TomAugspurger mentioned this pull request Jun 2, 2020
Closed
2 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 22, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

+1 more reviewer

@gfyoung gfyoung gfyoung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jbrockmendel @jreback @gfyoung @TomAugspurger