Skip to content

Groupby transform cleanups #27467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from Jul 25, 2019
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
071c9fa
Rename _is_cython_func to _get_cython_func
pilkibun Jul 19, 2019
0118cc8
typo
pilkibun Jul 19, 2019
2f29e4e
CLN: whitelist func in transform(func)
pilkibun Jul 19, 2019
45e9f70
comments
pilkibun Jul 19, 2019
0a1a0fb
tests
pilkibun Jul 19, 2019
b845034
black
pilkibun Jul 19, 2019
f45acd5
Deterministic test order for pytest collection
pilkibun Jul 19, 2019
514528b
use format()
pilkibun Jul 19, 2019
d662c9b
delete print func, now parameterized
pilkibun Jul 19, 2019
3c56a62
Make ita fixture
pilkibun Jul 19, 2019
52d4a61
typing
pilkibun Jul 19, 2019
a6a681a
black
pilkibun Jul 19, 2019
8b572ec
Merge remote-tracking branch 'origin/master' into groupby_transform_c…
pilkibun Jul 19, 2019
4e3ba63
Link issue
pilkibun Jul 19, 2019
0ad156b
sort names
pilkibun Jul 21, 2019
b1cb4b0
docstring
pilkibun Jul 21, 2019
d445de4
rename to use 'kernel'
pilkibun Jul 21, 2019
de2c59c
corr doesn't belong on the list
pilkibun Jul 21, 2019
bd73cff
comment
pilkibun Jul 21, 2019
f979ef8
Merge remote-tracking branch 'origin/master' into groupby_transform_c…
pilkibun Jul 21, 2019
7d7eecc
whatsnew
pilkibun Jul 21, 2019
d343686
Fix name in conftest.py
pilkibun Jul 21, 2019
6d0301a
test SeriesGroupby
pilkibun Jul 21, 2019
b6e924e
black
pilkibun Jul 21, 2019
399804c
remove cov
pilkibun Jul 22, 2019
1d158de
bfill is a reduction
pilkibun Jul 22, 2019
04dadd9
bfill is not a reduction I mean
pilkibun Jul 22, 2019
146e402
sort
pilkibun Jul 22, 2019
932d224
comment
pilkibun Jul 22, 2019
897d2fb
comment
pilkibun Jul 22, 2019
6a80828
comment
pilkibun Jul 22, 2019
2555193
remove stale test cases
pilkibun Jul 22, 2019
3d7bc64
remove duplicate test
pilkibun Jul 22, 2019
2b61329
Merge remote-tracking branch 'origin/master' into groupby_transform_c…
pilkibun Jul 22, 2019
053320b
CI
pilkibun Jul 23, 2019
994ab5f
Merge remote-tracking branch 'origin/master' into groupby_transform_c…
pilkibun Jul 23, 2019
6b90418
CI
pilkibun Jul 23, 2019
c932afd
TST: make sure every public method on Grouper is accounted for
pilkibun Jul 24, 2019
5f10720
comment
pilkibun Jul 24, 2019
4b186a4
comment
pilkibun Jul 24, 2019
de0c11c
comment
pilkibun Jul 24, 2019
cba02d6
fix review
pilkibun Jul 24, 2019
b19a46f
message
pilkibun Jul 24, 2019
3511480
Update test
pilkibun Jul 24, 2019
b5d3931
changes
pilkibun Jul 25, 2019
c97e2f2
Merge remote-tracking branch 'origin/master' into groupby_transform_c…
pilkibun Jul 25, 2019
e9343e1
reference issue
pilkibun Jul 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo
  • Loading branch information
pilkibun committed Jul 19, 2019
commit 0118cc89c4841b2ad7b6208e1f4f29fe6ad6d284
2 changes: 1 addition & 1 deletion pandas/core/groupby/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ def transform(self, func, *args, **kwargs):

obj = self._obj_with_exclusions

# nuiscance columns
# nuisance columns
if not result.columns.equals(obj.columns):
return self._transform_general(func, *args, **kwargs)

Expand Down