-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: Fix timezone-related indexing and plotting bugs #27367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
85a72d7
BUG: Series.__setitem__ with tuple and tz aware data
4be5326
Fix plotting DatetimeIndex with datetime.timezone.utc objects
14b09c6
black
a2af610
Address comments
98f3e11
Merge remote-tracking branch 'upstream/master' into fix_some_tz_bugs
e7bc381
Address comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
black
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -383,7 +383,7 @@ def test_constructor_data_aware_dtype_naive(self, tz_aware_fixture): | |
def test_numpy_reduction_with_tz_aware_dtype(self, tz_aware_fixture): | ||
# GH 15552 | ||
tz = tz_aware_fixture | ||
arg = to_datetime(['2019']).tz_localize(tz) | ||
arg = to_datetime(["2019"]).tz_localize(tz) | ||
expected = Series(arg) | ||
result = np.minimum(expected, expected) | ||
tm.assert_series_equal(result, expected) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might belong in tests.reductions? Especially if it can be extended to the other box classes |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to test_datetime (same dir)