Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST/CLN: replace %s formatting syntax with .format in tests #27324

Merged
merged 1 commit into from
Jul 10, 2019
Merged

TST/CLN: replace %s formatting syntax with .format in tests #27324

merged 1 commit into from
Jul 10, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #16130

@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite labels Jul 10, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 10, 2019
@jreback jreback merged commit 4edf938 into pandas-dev:master Jul 10, 2019
@jreback
Copy link
Contributor

jreback commented Jul 10, 2019

thanks @simonjayhawkins

are we in a position to code_check and fail for the old format?

@simonjayhawkins
Copy link
Member Author

are we in a position to code_check and fail for the old format?

i've only done the test directory here. we could start with a code check covering just that?

@jreback
Copy link
Contributor

jreback commented Jul 10, 2019

are we in a position to code_check and fail for the old format?

i've only done the test directory here. we could start with a code check covering just that?

sure, though I think most of the codebase is good actually, but happy to start having a check and can expand it later.

@simonjayhawkins simonjayhawkins deleted the use-format-syntax branch July 10, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback