Skip to content

ENH: Raise ValueError for unsupported Window functions #27275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 11, 2019
Merged

ENH: Raise ValueError for unsupported Window functions #27275

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8e03461
ENH: Raise ValueError for unsupported Window functions
ihsansecer Jul 7, 2019
b671484
Improve docs for win_type
ihsansecer Jul 7, 2019
693c9d1
Add whatsnew
ihsansecer Jul 7, 2019
e8b62b6
Catch AttributeError and raise ValueError instead
ihsansecer Jul 7, 2019
b65b9e5
Hangle list-like args
ihsansecer Jul 8, 2019
6be036f
Skip if no scipy
ihsansecer Jul 8, 2019
5fd5f50
Format using black
ihsansecer Jul 8, 2019
3988dab
Raise AttributeError instead of conflicting ValueError
ihsansecer Jul 10, 2019
dda8c3c
Merge remote-tracking branch 'upstream/master' into val-window-agg
ihsansecer Jul 10, 2019
1bf2e2a
Remove ' from whatsnew
ihsansecer Jul 10, 2019
03b4dae
Change ValueError with AttributeError and catch TypeError
ihsansecer Jul 10, 2019
a3e81cc
Test each function one by one
ihsansecer Jul 10, 2019
69ae66d
Test unknown function
ihsansecer Jul 10, 2019
d3b989e
Format
ihsansecer Jul 10, 2019
413123b
Merge remote-tracking branch 'upstream/master' into val-window-agg
ihsansecer Jul 11, 2019
546479b
Raise single error for invalid functions
ihsansecer Jul 11, 2019
0a03b00
Remove from doc
ihsansecer Jul 11, 2019
9b8baa0
Remove new line
ihsansecer Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test unknown function
  • Loading branch information
@ihsansecer
ihsansecer committed Jul 10, 2019
commit 69ae66d3963e8ba42c32ded3777e30c3ec49b92f
14 changes: 14 additions & 0 deletions pandas/tests/test_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,20 @@ def test_numpy_compat(self, method):
with pytest.raises(UnsupportedFunctionCall, match=msg):
getattr(e, method)(dtype=np.float64)

def test_agg_unknown(self):
df = pd.DataFrame({"A": np.arange(5)})
roll = df.rolling(2)

msg = "'foo' is an unknown string function"
with pytest.raises(AttributeError, match=msg):
roll.agg("foo")

with pytest.raises(AttributeError, match=msg):
roll.agg(["foo"])

with pytest.raises(AttributeError, match=msg):
roll.agg({"A": "foo"})


# gh-12373 : rolling functions error on float32 data
# make sure rolling functions works for different dtypes
Expand Down