Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix type annotations for Pandas.core.indexes.datetimelike #26365

Conversation

vaibhavhrt
Copy link
Contributor

@vaibhavhrt vaibhavhrt changed the title Pandas.core.indexes.datetimelike [WIP] Pandas.core.indexes.datetimelike May 13, 2019
@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented May 13, 2019

Errors that still remain are:

pandas\core\indexes\datetimelike.py:66: error: "Callable[[Any], Any]" has no attribute "fget"
pandas\core\indexes\datetimelike.py:67: error: "Callable[[Any], Any]" has no attribute "fget"
pandas\core\indexes\datetimelike.py:68: error: "Callable[[Any], Any]" has no attribute "fget"
pandas\core\indexes\datetimelike.py:70: error: "Callable[[Any], Any]" has no attribute "fget"
pandas\core\indexes\datetimelike.py:71: error: "Callable[[Any], Any]" has no attribute "fget"
pandas\core\indexes\datetimelike.py:208: error: Name '_box_values' already defined on line 73

Errors related to fget doesn't seem to have any solution yet(see python/mypy#6185 and linked mypy issues in its comments). Maybe we should ignore it for now.

@WillAyd need some insight on why _box_values is declared twice and how to annotate it, or maybe ignore it too.

btw mypy tests will fail, so maybe someone with access to azure pipelines should cancel the tests to allow tests from PR(if any) to run.

@vaibhavhrt vaibhavhrt changed the title [WIP] Pandas.core.indexes.datetimelike [WIP] Fix type annotations for Pandas.core.indexes.datetimelike May 13, 2019
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #26365 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26365      +/-   ##
==========================================
- Coverage   91.68%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50700    50701       +1     
==========================================
- Hits        46486    46483       -3     
- Misses       4214     4218       +4
Flag Coverage Δ
#multiple 90.18% <100%> (ø) ⬆️
#single 41.17% <100%> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimelike.py 98.14% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48d1ff...a817365. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented May 13, 2019

There is already an open PR for this one so closing this as a duplicate

@WillAyd WillAyd closed this May 13, 2019
@vaibhavhrt
Copy link
Contributor Author

my bad, didn't saw that

@vaibhavhrt vaibhavhrt deleted the pandas.core.indexes.datetimelike branch May 13, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix type annotations for pandas.core.indexes.datetimelike
2 participants