-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type annotation in pandas. version #25949
Fix type annotation in pandas. version #25949
Conversation
It's a little hard for me figure out what exactly is the type if key/values of the dictionary of both the variables I have typed. Please take a look if it's alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this pass locally for you? I think containers like Dict need the types to be explicitly stated as part of the annotation
… register_vcs_handler L52: LONG_VERSION_PY looks like dead.
Codecov Report
@@ Coverage Diff @@
## master #25949 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 175 175
Lines 52581 52581
==========================================
- Hits 48280 48275 -5
- Misses 4301 4306 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25949 +/- ##
==========================================
- Coverage 91.82% 89.73% -2.09%
==========================================
Files 175 175
Lines 52581 56159 +3578
==========================================
+ Hits 48280 50397 +2117
- Misses 4301 5762 +1461
Continue to review full report at Codecov.
|
Someone please take a look at the travis tests. It has passed on travis but it's stuck on pending here for quite some time. |
Just restarted it to make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I think this works. We might want to revisit the decorator typing options as they evolve in MyPy but I don't think that's a blocker for this PR.
this is fine, we don't expect to edit this file anyhow, its just for import time versions |
Also remove this module from
mypy.ini
git diff upstream/master -u -- "*.py" | flake8 --diff