Skip to content

BUG: Fix index type casting in read_json with orient='table' and float index (#25433) #25434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 28, 2019
Merged

BUG: Fix index type casting in read_json with orient='table' and float index (#25433) #25434

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f536046
Fix bug when index type casting in read_json table (#25433)
Feb 24, 2019
98333da
Fix test
Feb 24, 2019
7cf9716
Add tests (#25435)
Feb 24, 2019
c0bce78
Address requested changes
Feb 25, 2019
85fddb0
Test error message matches
Feb 25, 2019
fd0822b
Address requested changes
Feb 26, 2019
5c5f3d6
Fix test
Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test error message matches
  • Loading branch information
Albert Villanova del Moral committed Feb 25, 2019
commit 85fddb084aaf392908b16d35cac64ab718d9a9de
6 changes: 4 additions & 2 deletions pandas/tests/io/json/test_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,14 +1224,16 @@ def test_read_json_table_dtype_raises(self, dtype):
# GH21345
df = pd.DataFrame({'a': [1, 2], 'b': [3., 4.], 'c': ['5', '6']})
dfjson = df.to_json(orient='table')
with pytest.raises(ValueError):
msg = "cannot pass both dtype and orient='table'"
with pytest.raises(ValueError, match=msg):
pd.read_json(dfjson, orient='table', dtype=dtype)

def test_read_json_table_convert_axes_raises(self):
# GH25433 GH25435
df = DataFrame([[1, 2], [3, 4]], index=[1., 2.], columns=['1.', '2.'])
dfjson = df.to_json(orient='table')
with pytest.raises(ValueError):
msg = "cannot pass both convert_axes and orient='table'"
with pytest.raises(ValueError, match=msg):
pd.read_json(dfjson, orient='table', convert_axes=True)

@pytest.mark.parametrize('data, expected', [
Expand Down