Skip to content

Fix PR10 error and Clean up docstrings from functions related to RT05 errors #25132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Mar 1, 2019
Merged

Fix PR10 error and Clean up docstrings from functions related to RT05 errors #25132

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2c4455c
Fix validation error RT05
thoo Feb 4, 2019
c87102f
Fix pep8
thoo Feb 4, 2019
d552569
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 4, 2019
03aaa92
fix merge conflict
thoo Feb 4, 2019
36a610a
fix RT04
thoo Feb 4, 2019
c2e24b3
fix as recommended
thoo Feb 5, 2019
f5cfc8a
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 5, 2019
6e658f8
fix bullets
thoo Feb 5, 2019
5304b9c
fix upon suggestions
thoo Feb 6, 2019
7601aed
fix upon suggestions
thoo Feb 6, 2019
128dadb
fix failing tests
thoo Feb 6, 2019
3d3e408
replace with bullet
thoo Feb 6, 2019
522e76d
typo
thoo Feb 6, 2019
163e9e3
Retrigger :pandas-dev conda 27 failed
thoo Feb 6, 2019
b55b270
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 7, 2019
ba4f001
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 8, 2019
25e7503
update code_checks.sh
thoo Feb 8, 2019
1824b99
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 11, 2019
1262632
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 16, 2019
e12ee2a
fix as recommended
thoo Feb 16, 2019
bfe30f8
fix some leftover
thoo Feb 16, 2019
d5d270b
Retrigger :pandas-devs failed
thoo Feb 17, 2019
6ac909b
Retrigger :pandas-devs failed second time
thoo Feb 17, 2019
4e4f24a
Retrigger :pandas-devs failed second time
thoo Feb 17, 2019
283861f
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 17, 2019
953159c
fix at Series.unique
thoo Feb 20, 2019
15fde16
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 20, 2019
94e5279
add PR10
thoo Feb 21, 2019
39ab010
drop PR10
thoo Feb 21, 2019
64bd51b
fix PR10 error
thoo Feb 21, 2019
7051e3c
fix as recommended
thoo Feb 22, 2019
a35f869
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 22, 2019
b847e4e
fix as recommended
thoo Feb 22, 2019
2d62018
Merge remote-tracking branch 'upstream/master' into Rt05
thoo Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into Rt05 
* upstream/master:
  BUG: Fix exceptions when Series.interpolate's `order` parameter is missing or invalid (#25246)
  API: Ensure DatetimeTZDtype standardizes pytz timezones (#25254)
  Split Excel IO Into Sub-Directory (#25153)
  PR04 errors fix (#25157)
  DEPR: remove assert_panel_equal (#25238)
  BUG: pandas Timestamp tz_localize and tz_convert do not preserve `freq` attribute (#25247)
  Revert "BLD: prevent asv from calling sys.stdin.close() by using different launch method (#25237)" (#25253)
  REF/TST: resample/test_base.py (#25262)
  BUG: Duplicated returns boolean dataframe (#25234)
  CLN: Remove ipython 2.x compat (#25150)
  Refactor groupby group_add from tempita to fused types (#24954)
  CLN: For loops, boolean conditions, misc. (#25206)
  (Closes #25029) Removed extra bracket from cheatsheet code example. (#25032)
  BLD: prevent asv from calling sys.stdin.close() by using different launch method (#25237)
  BUG: Fix read_json orient='table' without index (#25170) (#25171)
  BUG: Fix regression in DataFrame.apply causing RecursionError (#25230)
  BUG-25061 fix printing indices with NaNs (#25202)
  DEPR: Add Deprecated warning for timedelta with passed units M and Y  (#23264)
  DEPR: Remove Panel-specific parts of io.pytables (#25233)
  DEPR: remove tm.makePanel and all usages (#25231)
  • Loading branch information
@thoo
thoo committed Feb 11, 2019
commit 1824b99ae8b5f77262c900129ad55cd33e749c0a
4 changes: 2 additions & 2 deletions ci/code_checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ fi
### DOCSTRINGS ###
if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then

MSG='Validate docstrings (GL06, GL07, GL09, SS04, SS05, PR03, PR05, EX04, RT04, RT05, SA05)' ; echo $MSG
$BASE_DIR/scripts/validate_docstrings.py --format=azure --errors=GL06,GL07,GL09,SS04,SS05,PR03,PR05,EX04,RT04,RT05,SA05
MSG='Validate docstrings (GL06, GL07, GL09, SS04, SS05, PR03, PR04, PR05, EX04, RT04, RT05, SA05)' ; echo $MSG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for removing PR10 here or just mistake?

Copy link
Contributor Author

@thoo thoo Feb 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a mistake from merge.

Copy link
Contributor Author

@thoo thoo Feb 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR10 is actually not included in the current check at line 245. So I wasn't sure someone exclude PR10 but forgot to remove from the message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think this was just missed in #25109 so makes sense to update here accordingly

Copy link
Contributor Author

@thoo thoo Feb 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

##[error]pandas/io/excel/_base.py(492,): error PR10: pandas.ExcelWriter: Parameter ".. versionadded" requires a space before the colon separating the parameter name and type

PR10 is not passing the check with .. versionadded:: 0.24.. I am going to leave PR10 for now. Update pandas.ExcelWriter

$BASE_DIR/scripts/validate_docstrings.py --format=azure --errors=GL06,GL07,GL09,SS04,SS05,PR03,PR04,PR05,EX04,RT04,RT05,SA05
RET=$(($RET + $?)) ; echo $MSG "DONE"

fi
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.