Fix DeprecationWarning: invalid escape sequence in versioneer.py #24636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
|
Hello @BoboTiG! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 05, 2019 at 15:37 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #24636 +/- ##
===========================================
- Coverage 92.38% 43% -49.38%
===========================================
Files 166 166
Lines 52395 52395
===========================================
- Hits 48403 22534 -25869
- Misses 3992 29861 +25869
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24636 +/- ##
==========================================
- Coverage 92.38% 92.37% -0.01%
==========================================
Files 166 166
Lines 52395 52379 -16
==========================================
- Hits 48403 48386 -17
- Misses 3992 3993 +1
Continue to review full report at Codecov.
|
jreback
requested changes
Jan 5, 2019
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1731,6 +1731,7 @@ Other | |||
|
|
|||
| - Bug where C variables were declared with external linkage causing import errors if certain other C libraries were imported before Pandas. (:issue:`24113`) | |||
| - Require at least 0.28.2 version of ``cython`` to support read-only memoryviews (:issue:`21688`) | |||
| - Fixing a `DeprecationWarning`: invalid escape sequence in versioneer.py (:issue:`24636`) | |||
There was a problem hiding this comment.
Done, I was not sure at first and added it after :)
jreback
added
the
Compat
This reverts commit 4790787.
jreback
approved these changes
Jan 5, 2019
|
lgtm. ping on green. |
|
thanks! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a little patch to fix a
DeprecationWarning: invalid escape sequenceinversioneer.py.git diff upstream/master -u -- "*.py" | flake8 --diff