Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/TST: Add more pytest idiom to test_read_fwf.py #24361

Merged
merged 1 commit into from
Dec 19, 2018
Merged

REF/TST: Add more pytest idiom to test_read_fwf.py #24361

merged 1 commit into from
Dec 19, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 19, 2018 •
edited
Loading

Also refactors out a compression writing utility function originally just for test_compression.py.

xref #22200 (comment)

@gfyoung
REF/TST: Add more pytest idiom to test_read_fwf.py
8e77117 
Also refactors out a compression writing utility
function originally just for test_compression
in the same directory.
@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Dec 19, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Dec 19, 2018
@codecov
Copy link

codecov bot commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #24361 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24361      +/-   ##
==========================================
- Coverage   92.29%   92.29%   -0.01%     
==========================================
  Files         162      162              
  Lines       51808    51832      +24     
==========================================
+ Hits        47817    47839      +22     
- Misses       3991     3993       +2
Flag Coverage Δ
#multiple 90.7% <91.66%> (ø) ⬆️
#single 42.98% <4.16%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.66% <91.66%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c33b0...8e77117. Read the comment docs.

@pandas-dev pandas-dev deleted a comment from codecov bot Dec 19, 2018
@jreback jreback merged commit 1c37ce9 into pandas-dev:master Dec 19, 2018
@jreback
Copy link
Contributor

jreback commented Dec 19, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the pytest-idiom-read-fwf branch December 19, 2018 23:00
@gfyoung gfyoung mentioned this pull request Dec 19, 2018
Merged
4 tasks
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 20, 2018
@gfyoung @TomAugspurger
REF/TST: Add more pytest idiom to test_read_fwf.py (pandas-dev#24361)
0d2eb42 
Also refactors out a compression writing utility
function originally just for test_compression
in the same directory.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
REF/TST: Add more pytest idiom to test_read_fwf.py (pandas-dev#24361)
be2b34e 
Also refactors out a compression writing utility
function originally just for test_compression
in the same directory.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
REF/TST: Add more pytest idiom to test_read_fwf.py (pandas-dev#24361)
b148559 
Also refactors out a compression writing utility
function originally just for test_compression
in the same directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyoung @jreback