Skip to content

BUG: Assorted DatetimeIndex bugfixes #24157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Dec 14, 2018
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
092b3b9
Deprecate time_rule
jbrockmendel Dec 7, 2018
fbcc04b
cleanup
jbrockmendel Dec 7, 2018
ac52857
fix test
jbrockmendel Dec 7, 2018
121c373
Fix indexing with ellipsis, GH#21282
jbrockmendel Dec 7, 2018
ef66bb9
isort tests.arithmetic, tests.dtypes
jbrockmendel Dec 7, 2018
91738d3
raise on date_range with NaT for either start or end
jbrockmendel Dec 7, 2018
bb0d065
revert noncentral changes
jbrockmendel Dec 7, 2018
ff3a5c0
more useful error messages on validate_frequency failure
jbrockmendel Dec 7, 2018
e54159d
Fix DTI-->Categorical -->DTI roundtrip
jbrockmendel Dec 7, 2018
44e0126
extend test to DTA
jbrockmendel Dec 8, 2018
12e0f4e
comment
jbrockmendel Dec 8, 2018
28bf2de
update GH reference
jbrockmendel Dec 8, 2018
06d0a8e
make TDI catch nanos valuerror
jbrockmendel Dec 8, 2018
81c7d0f
fix error message, hopefully
jbrockmendel Dec 8, 2018
97f976f
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 8, 2018
9e55d97
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 9, 2018
c7f280f
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 9, 2018
af303c7
improve comments
jbrockmendel Dec 9, 2018
8ece686
use take
jbrockmendel Dec 9, 2018
30f01a0
whitespace
jbrockmendel Dec 9, 2018
9617b85
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 11, 2018
3731098
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 13, 2018
df05c88
do ellipsis check later
jbrockmendel Dec 13, 2018
8f39b23
Avoid AssertionError
jbrockmendel Dec 13, 2018
e958ce6
remove resolved comment
jbrockmendel Dec 13, 2018
97cb6b3
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
jbrockmendel Dec 13, 2018
36d37e4
more whatsnew
jbrockmendel Dec 13, 2018
3fc1c19
comment harder
jbrockmendel Dec 13, 2018
88f7094
comment harder
jbrockmendel Dec 13, 2018
e178bb9
remove time_rule entirely
jbrockmendel Dec 13, 2018
50f6b7e
whatsnew
jbrockmendel Dec 13, 2018
b927925
flake8 fixup
jbrockmendel Dec 13, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of https://github.com/pandas-dev/pandas into deets
  • Loading branch information
jbrockmendel committed Dec 11, 2018
commit 9617b8511c0ccce6afe15d5a260b02c6649d999c
2 changes: 2 additions & 0 deletions doc/source/whatsnew/v0.24.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1103,6 +1103,8 @@ Deprecations
- :func:`pandas.types.is_datetimetz` is deprecated in favor of `pandas.types.is_datetime64tz` (:issue:`23917`)
- Creating a :class:`TimedeltaIndex` or :class:`DatetimeIndex` by passing range arguments `start`, `end`, and `periods` is deprecated in favor of :func:`timedelta_range` and :func:`date_range` (:issue:`23919`)
- Passing a string alias like ``'datetime64[ns, UTC]'`` as the `unit` parameter to :class:`DatetimeTZDtype` is deprecated. Use :class:`DatetimeTZDtype.construct_from_string` instead (:issue:`23990`).
- In :meth:`Series.where` with Categorical data, providing an ``other`` that is not present in the categories is deprecated. Convert the categorical to a different dtype or add the ``other`` to the categories first (:issue:`24077`).
- :meth:`Series.clip_lower`, :meth:`Series.clip_upper`, :meth:`DataFrame.clip_lower` and :meth:`DataFrame.clip_upper` are deprecated and will be removed in a future version. Use ``Series.clip(lower=threshold)``, ``Series.clip(upper=threshold)`` and the equivalent ``DataFrame`` methods (:issue:`24203`)
- Passing a `time_rule` to `pandas.tseries.offsets.generate_range` is deprecated and will raise a ``TypeError`` in a future version. Pass an ``offset`` instead (:issue:`24157`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these don't jive with what's at the top of the PR. missing 2 notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about #11587 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it merit a note? All that is changed is an error message. But yes, this does close 11587, I'll update this above.


.. _whatsnew_0240.deprecations.datetimelike_int_ops:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.