-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
CLN: io/formats/html.py: refactor #23818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @simonjayhawkins! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23818 +/- ##
==========================================
- Coverage 92.28% 92.28% -0.01%
==========================================
Files 161 161
Lines 51500 51494 -6
==========================================
- Hits 47528 47522 -6
Misses 3972 3972
Continue to review full report at Codecov.
|
gfyoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
these changes are ok, though @simonjayhawkins pls add a note anyhow in api breaking changes (they are private but just a notice) |
gfyoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jreback
|
thanks @simonjayhawkins |
added/ passedgit diff upstream/master -u -- "*.py" | flake8 --diffremove
max_rowsandmax_colsfromHTMLFormatteras truncation is now handled byDataFrameFormatternote: this PR should be orthogonal to #22655