Skip to content

REF/ENH: Constructors for DatetimeArray/TimedeltaArray #23493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

REF/ENH: Constructors for DatetimeArray/TimedeltaArray #23493

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f25d24c
implement _from_sequence
jbrockmendel Nov 4, 2018
e47c200
Add dtype to periodArray.__init__
jbrockmendel Nov 4, 2018
2cb7597
implement require_m8ns_dtype, from_sequence
jbrockmendel Nov 4, 2018
a4512b7
small cleanups in datetimeIndex.__new
jbrockmendel Nov 4, 2018
a5ef959
dispatch parts of TimedeltaIndex.__new__
jbrockmendel Nov 4, 2018
83b04fe
add copy to constructors
jbrockmendel Nov 4, 2018
e8abc83
small cleanup
jbrockmendel Nov 4, 2018
a4c8671
Merge branch 'master' of https://github.com/pandas-dev/pandas into pr…
jbrockmendel Nov 4, 2018
98dca45
implement maybe_define_freq
jbrockmendel Nov 4, 2018
56fd95e
handle ABSeries
jbrockmendel Nov 4, 2018
5f92cfa
implement basic constructor tests, fix just enough of the comparisons…
jbrockmendel Nov 4, 2018
0e15536
add note
jbrockmendel Nov 4, 2018
1a015f6
flake8 fixup
jbrockmendel Nov 4, 2018
5445a56
implement scalar_data_error, with tests
jbrockmendel Nov 4, 2018
272f4b1
docstring
jbrockmendel Nov 4, 2018
35195bd
Fix TimedeltaArray infer_freq; implement tests
jbrockmendel Nov 5, 2018
bb394dc
Merge branch 'master' of https://github.com/pandas-dev/pandas into pr…
jbrockmendel Nov 5, 2018
510ae3d
update tests for changed exception type
jbrockmendel Nov 5, 2018
49cf495
remove redundant dtype check
jbrockmendel Nov 5, 2018
3a62633
implement maybe_validate_freq
jbrockmendel Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redundant dtype check
  • Loading branch information
@jbrockmendel
jbrockmendel committed Nov 5, 2018
commit 49cf4952ab17b367543721a5f871704d1a4ddbab
5 changes: 0 additions & 5 deletions pandas/core/indexes/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,6 @@ def __new__(cls, data=None,
assert subarr.dtype == 'M8[ns]', subarr.dtype

subarr = cls._simple_new(subarr, name=name, freq=freq, tz=tz)
if dtype is not None:
if not is_dtype_equal(subarr.dtype, dtype):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is made unnecessary by the tz = dtl.validate_tz_from_dtype(dtype, tz) above (implemented a couple PRs ago)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this isn't quite right. Will revert/fix.

# dtype must be coerced to DatetimeTZDtype above
if subarr.tz is not None:
raise ValueError("cannot localize from non-UTC data")

if verify_integrity and len(subarr) > 0:
if freq is not None and not freq_infer:
Expand Down