Skip to content

Conversation

@mroeschke
Copy link
Member

Removed one dead tutorial link and updated our doc links to https where available.

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #23476 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23476   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51197    51197           
=======================================
  Hits        47220    47220           
  Misses       3977     3977
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 96.41% <0%> (ø) ⬆️
pandas/core/indexes/api.py 99% <0%> (ø) ⬆️
pandas/core/generic.py 96.81% <0%> (ø) ⬆️
pandas/core/arrays/datetimes.py 98.84% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78bd7a...7b50cd0. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mroeschke

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pandas-dev/pandas/search?q=http%3A

@mroeschke : Were you trying to remove all of them, or just a subset?

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues. merge on green.

-------------------------------

`Statsmodels <http://www.statsmodels.org/>`__
`Statsmodels <https://www.statsmodels.org/>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you have to make this the same length

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean. These are rendering okay and hyperlink to the correct page when I run it locally.

screen shot 2018-11-04 at 9 11 04 am

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are doc warnings on building i think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I see them. Will fix and push on green



`Bokeh <http://bokeh.pydata.org>`__
`Bokeh <https://bokeh.pydata.org>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same and so on

@jreback jreback added this to the 0.24.0 milestone Nov 4, 2018
@mroeschke
Copy link
Member Author

@gfyoung just a subset, some of the links don't support https yet...

@mroeschke mroeschke merged commit 7c36868 into pandas-dev:master Nov 5, 2018
@mroeschke mroeschke deleted the doc_link_updating branch November 5, 2018 05:19
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
* DOC: Remove dead links and update links to https

* Add missing ~
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
* DOC: Remove dead links and update links to https

* Add missing ~
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* DOC: Remove dead links and update links to https

* Add missing ~
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* DOC: Remove dead links and update links to https

* Add missing ~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants