Skip to content

Run Isort on tests/arrays single PR #23346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2018

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Oct 25, 2018

@pep8speaks
Copy link

Hello @thoo! Thanks for submitting the PR.

@thoo thoo force-pushed the fix_import_format_arrays branch from 7564890 to a8ab9e8 Compare October 25, 2018 22:18
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to setup.cfg needed?

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

needs a rebase

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c238620). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23346   +/-   ##
=========================================
  Coverage          ?   92.22%           
=========================================
  Files             ?      169           
  Lines             ?    51258           
  Branches          ?        0           
=========================================
  Hits              ?    47274           
  Misses            ?     3984           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.66% <ø> (?)
#single 42.23% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c238620...e1867ce. Read the comment docs.

@thoo thoo force-pushed the fix_import_format_arrays branch from 59e68c4 to 42b15a2 Compare October 26, 2018 03:42
@thoo
Copy link
Contributor Author

thoo commented Oct 28, 2018

@jreback This one is also green. Thanks.

@jreback jreback merged commit 2360f5a into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks!

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@thoo thoo deleted the fix_import_format_arrays branch January 2, 2019 20:26
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants