Skip to content

BUG: DataFrame.to_dict when orient=index data loss #22810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 11, 2018
Merged

BUG: DataFrame.to_dict when orient=index data loss #22810

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8164725
Raise ValueError on DataFrame.to_dict when orient=index and index is …
jameswinegar Sep 23, 2018
616db89
change to numpy based size and use methods. Fix test to create datafr…
jameswinegar Sep 23, 2018
9949fb7
fix pep8
jameswinegar Sep 23, 2018
8522e13
fix reference to dataframe as self
jameswinegar Sep 23, 2018
df58b9d
adjust for @jreback comments
jameswinegar Sep 23, 2018
2de5e0a
Merge branch 'master' of https://github.com/pandas-dev/pandas
jameswinegar Sep 23, 2018
51e42da
add documentation and get origin to avoid merge conflict
jameswinegar Sep 23, 2018
0a49ffc
move documentation and reword for clarity and consistency
jameswinegar Sep 23, 2018
abeda10
resolve merge conflict
jameswinegar Sep 24, 2018
6eb2e5a
Update v0.24.0.txt
jameswinegar Sep 25, 2018
317555b
resolve merge conflict
jameswinegar Oct 2, 2018
f457cd4
Merge branch 'master' into master
jameswinegar Oct 2, 2018
0da33da
Merge branch 'master' of https://github.com/jameswinegar/pandas
jameswinegar Oct 2, 2018
4c57b78
Merge branch 'master' of https://github.com/pandas-dev/pandas
jameswinegar Oct 8, 2018
fb2eff0
less verbose whatsnew
jameswinegar Oct 8, 2018
7a4240e
Update v0.24.0.txt
jameswinegar Oct 10, 2018
a5e8945
Update v0.24.0.txt
jameswinegar Oct 11, 2018
6aec074
Update v0.24.0.txt
jameswinegar Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
less verbose whatsnew
  • Loading branch information
@jameswinegar
jameswinegar committed Oct 8, 2018
commit fb2eff0c7428dd260f6756a08042b76c7d049083
23 changes: 0 additions & 23 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,29 +381,6 @@ Raise ValueError in ``DataFrame.to_dict(orient='index')``
Bug in :func:`DataFrame.to_dict` raises ``ValueError`` when used with
``orient='index'`` and a non-unique index instead of losing data (:issue:`22801`)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a mini-example here (just showing what kind of data frame will raise). the prior example was too long, but I think we need something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an ipython block that will raise the error. @jreback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right but now the docs will not work. so, you can do this as an ipython block but you need an :okexcept: to handle the exception.

also show the df after defining it

Previous Behavior:

Calling :func:`DataFrame.to_dict` resulted in data loss when ``orient='index'``
for non-unique indexes

.. code-block:: ipython

In [2]: df = pd.DataFrame({'a': [1, 2], 'b': [0.5, 0.75]}, index=['A', 'A'])

In [3]: df.to_dict(orient='index')
Out [3]: {'A': {'a': 2.0, 'b': 0.75}}

Current Behavior:

Calling :func:`DataFrame.to_dict` will now result in a ValueError being raised
when ``orient='index'`` for non-unique index values

.. ipython:: python

df = pd.DataFrame({'a': [1, 2], 'b': [0.5, 0.75]}, index=['A', 'A'])

df.to_dict(orient='index')

.. _whatsnew_0240.api.datetimelike.normalize:

Tick DateOffset Normalize Restrictions
Expand Down