Skip to content

CLN/DEPR: removed deprecated as_indexer arg from str.match() #22356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

CLN/DEPR: removed deprecated as_indexer arg from str.match() #22356

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c079870
removed as_indexer(deprecated of 0.21.0) completely from str.match()
HyunTruth Aug 15, 2018
f6612aa
changed tests to suit removal of as_indexer from str.match()
HyunTruth Aug 15, 2018
72f74b2
remove tests for the same points
HyunTruth Aug 15, 2018
ce529e9
Added whatsnew and updated copy decorator(match) to not use as_indexe…
HyunTruth Aug 15, 2018
454612e
fixed assertion on the new test
HyunTruth Aug 15, 2018
db7f34e
changed regex of the test to the output from tests
HyunTruth Aug 15, 2018
07cff36
assertion regex to exclude the func name
HyunTruth Aug 15, 2018
23604e9
applied suggested changes to whatsnew
HyunTruth Aug 15, 2018
b109d19
deleted the corresponding tests in `test_match` for `as_indexer`
HyunTruth Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove tests for the same points
  • Loading branch information
@HyunTruth
HyunTruth committed Aug 15, 2018
commit 72f74b2da4b1b6a48967616775212a9ee6d1d228
10 changes: 0 additions & 10 deletions pandas/tests/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,16 +946,6 @@ def test_match(self):
"unexpected keyword "
"argument 'as_indexer'"):
result = values.str.match('.*BAD[_]+.*BAD', as_indexer=True)
with tm.assert_raises_regex(TypeError,
"str_match() got an "
"unexpected keyword "
"argument 'as_indexer'"):
result = values.str.match('.*BAD[_]+.*BAD', as_indexer=False)
with tm.assert_raises_regex(TypeError,
"str_match() got an "
"unexpected keyword "
"argument 'as_indexer'"):
result = values.str.match('.*(BAD[_]+).*(BAD)', as_indexer=True)

# mixed
mixed = Series(['aBAD_BAD', NA, 'BAD_b_BAD', True, datetime.today(),
Expand Down