Skip to content

API: ExtensionDtype._is_numeric #22345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2018
Merged

API: ExtensionDtype._is_numeric #22345

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5064217
API: ExtensionDtype._is_numeric
TomAugspurger Aug 14, 2018
50de326
fixed test
TomAugspurger Aug 14, 2018
1d96d22
added test for DataFrame._get_numeric_data
jschendel Aug 15, 2018
db9af36
Pass ndim
TomAugspurger Aug 15, 2018
a3fdc2a
Note plotting
TomAugspurger Aug 15, 2018
fc34131
Merge branch 'ea-is-numeric' of https://github.com/TomAugspurger/pand…
TomAugspurger Aug 15, 2018
2779419
small edit
jorisvandenbossche Aug 20, 2018
e813855
Merge branch 'master' into ea-is-numeric
jorisvandenbossche Aug 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pandas/tests/frame/test_block_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
import numpy as np

from pandas import (DataFrame, Series, Timestamp, date_range, compat,
option_context)
option_context, Categorical)
from pandas.core.arrays import IntegerArray, IntervalArray
from pandas.compat import StringIO
import pandas as pd

Expand Down Expand Up @@ -436,6 +437,17 @@ def test_get_numeric_data(self):
expected = df
assert_frame_equal(result, expected)

def test_get_numeric_data_extension_dtype(self):
# GH 22290
df = DataFrame({
'A': IntegerArray([-10, np.nan, 0, 10, 20, 30], dtype='Int64'),
'B': Categorical(list('abcabc')),
'C': IntegerArray([0, 1, 2, 3, np.nan, 5], dtype='UInt8'),
'D': IntervalArray.from_breaks(range(7))})
result = df._get_numeric_data()
expected = df.loc[:, ['A', 'C']]
assert_frame_equal(result, expected)

def test_convert_objects(self):

oops = self.mixed_frame.T.T
Expand Down