Skip to content

BUG: Fix DataFrame construction regression #22232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 8, 2018
Merged

BUG: Fix DataFrame construction regression #22232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a0bf3b7
Add test
cpcloud Aug 7, 2018
26f2b88
whatsnew
cpcloud Aug 7, 2018
153bbd4
Fix test
cpcloud Aug 7, 2018
a98c81d
Actually fix the bug
cpcloud Aug 7, 2018
7805f5f
Construct without dicts
cpcloud Aug 7, 2018
2db6efe
Move to pandas/tests/frame/test_constructors.py
cpcloud Aug 7, 2018
fa33822
Add gh comment
cpcloud Aug 7, 2018
8039b33
Move to v0.23.5 whatsnew
cpcloud Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew
  • Loading branch information
@cpcloud
cpcloud committed Aug 7, 2018
commit 26f2b888cd9bc367e12a543b0660a8b942967d05
7 changes: 7 additions & 0 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,13 @@ Other
- :meth: `~pandas.io.formats.style.Styler.background_gradient` now takes a ``text_color_threshold`` parameter to automatically lighten the text color based on the luminance of the background color. This improves readability with dark background colors without the need to limit the background colormap range. (:issue:`21258`)
- Require at least 0.28.2 version of ``cython`` to support read-only memoryviews (:issue:`21688`)
- :meth: `~pandas.io.formats.style.Styler.background_gradient` now also supports tablewise application (in addition to rowwise and columnwise) with ``axis=None`` (:issue:`15204`)

Regressions
~~~~~~~~~~~

- Constructing a DataFrame with an index argument that wasn't already an
instance of :class:`~pandas.core.Index` was broken in `4efb39f
<https://github.com/pandas-dev/pandas/commit/4efb39f01f5880122fa38d91e12d217ef70fad9e>`_ (:issue:`22227`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we created a separate Regressions section in the whatsnew ? Generally, we just put regression bugs in the bugs section and don't "call out" the offending commits like this.

Copy link
Member Author

@cpcloud cpcloud Aug 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, keeping track of the number of regressions over time is an important indicator of stability of a project. I think pandas is fairly stable with respect to regression, and I think it's important that we know how often regressions are happening.

The specific commit is there for minimizing the number of clicks someone has to perform to see exactly what code introduced the regression.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so actually 0.23.5 whatsnew is now pushed, let backport this, can you move the whatsnew. ping when pushed

-
-
-