Skip to content

TST: restructure internal extension arrays tests (split between /arrays and /extension) #22026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f3e3085
Split integer array tests in tests/arrays/integer and tests/extension…
jorisvandenbossche Jul 23, 2018
6408ee0
split interval tests
jorisvandenbossche Jul 23, 2018
de10591
use tm.assert methods instead of class methods
jorisvandenbossche Jul 24, 2018
1c40fd7
fix py2
jorisvandenbossche Jul 24, 2018
facfc44
linter
jorisvandenbossche Jul 24, 2018
6edec38
move test_integer/test_interval/test_categorical to main tests/extens…
jorisvandenbossche Jul 26, 2018
39e46c9
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Jul 26, 2018
cb1350f
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Aug 16, 2018
5574c11
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Aug 21, 2018
a17deda
get tests passing
jorisvandenbossche Aug 21, 2018
41b2615
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Aug 22, 2018
8cf71e9
add module docstring to each test file
jorisvandenbossche Aug 22, 2018
edcb3da
fix rebase mistake
jorisvandenbossche Aug 23, 2018
96a9a8b
absolute import
jorisvandenbossche Aug 23, 2018
700c405
remove BaseInteger with assert overwrites
jorisvandenbossche Aug 23, 2018
c28cab9
fix linter
jorisvandenbossche Aug 23, 2018
6ced029
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Sep 5, 2018
c2644cb
Merge remote-tracking branch 'upstream/master' into restructure-array…
jorisvandenbossche Sep 5, 2018
db2836c
pep8
jorisvandenbossche Sep 5, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter
  • Loading branch information
jorisvandenbossche committed Jul 24, 2018
commit facfc445f7861641eb888f07cfa1fcb5d44d1ffc
6 changes: 3 additions & 3 deletions pandas/tests/arrays/test_integer.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_dtypes(dtype):
assert dtype.name is not None


class TestInterface:
class TestInterface(object):

def test_repr_array(self, data):
result = repr(data)
Expand All @@ -79,7 +79,7 @@ def test_repr_array_long(self, data):
assert 'length' in result


class TestConstructors:
class TestConstructors(object):

def test_from_dtype_from_float(self, data):
# construct from our dtype & string dtype
Expand Down Expand Up @@ -318,7 +318,7 @@ def test_compare_array(self, data, all_compare_operators):
self._compare_other(s, data, op_name, other)


class TestCasting:
class TestCasting(object):
pass

@pytest.mark.parametrize('dropna', [True, False])
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/arrays/test_interval.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def left_right_dtypes(request):
return request.param


class TestMethods:
class TestMethods(object):

@pytest.mark.parametrize('repeats', [0, 1, 5])
def test_repeat(self, left_right_dtypes, repeats):
Expand Down Expand Up @@ -51,7 +51,7 @@ def test_set_closed(self, closed, new_closed):
tm.assert_extension_array_equal(result, expected)


class TestSetitem:
class TestSetitem(object):

def test_set_na(self, left_right_dtypes):
left, right = left_right_dtypes
Expand Down