Skip to content

CLN: De-privatize core.common funcs, remove unused #22001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 24, 2018
Merged

CLN: De-privatize core.common funcs, remove unused #22001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f27bf4d
Move (mostly deprecated) frontend detection to io.formats.console
jbrockmendel Jul 20, 2018
cd6d6b0
deprivatize maybe_box
jbrockmendel Jul 20, 2018
95c90a1
deprivatize asarray_tuplesafe
jbrockmendel Jul 20, 2018
2af7d33
Deprivatize apply_if_callable
jbrockmendel Jul 20, 2018
f76712c
remove unused _long_prod
jbrockmendel Jul 20, 2018
0fe4b8b
remove unused _mut_exclusive
jbrockmendel Jul 20, 2018
6b7fd33
Fixup missed changes
jbrockmendel Jul 20, 2018
c0e4370
deprivatize get_callable_name
jbrockmendel Jul 20, 2018
a3f1b9d
depricatize try_sort, dict_keys_to_ordered_list
jbrockmendel Jul 20, 2018
072f7cb
deprivatize most of the rest of com
jbrockmendel Jul 20, 2018
beb280b
Flake8 fixups
jbrockmendel Jul 20, 2018
5264a0d
remove unused set functions
jbrockmendel Jul 20, 2018
7430b96
remove unused groupby
jbrockmendel Jul 20, 2018
a34fe9f
remove unused split_ranges
jbrockmendel Jul 20, 2018
cc28772
remove unused iterpairs
jbrockmendel Jul 20, 2018
892ba57
flake8 fixup unused imports
jbrockmendel Jul 20, 2018
71f7dfd
Merge branch 'master' of https://github.com/pandas-dev/pandas into com
jbrockmendel Jul 24, 2018
00ba0d0
whatsnew note, comment in docstring
jbrockmendel Jul 24, 2018
8e5a1bd
Merge branch 'master' of https://github.com/pandas-dev/pandas into com
jbrockmendel Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup missed changes
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jul 20, 2018
commit 6b7fd33b9d5861808c4442aec57f60341233a298
4 changes: 2 additions & 2 deletions pandas/core/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def intersection(*seqs):
return type(seqs[0])(list(result))


def _asarray_tuplesafe(values, dtype=None):
def asarray_tuplesafe(values, dtype=None):

if not (isinstance(values, (list, tuple)) or hasattr(values, '__array__')):
values = list(values)
Expand Down Expand Up @@ -318,7 +318,7 @@ def _index_labels_to_array(labels, dtype=None):
except TypeError: # non-iterable
labels = [labels]

labels = _asarray_tuplesafe(labels, dtype=dtype)
labels = asarray_tuplesafe(labels, dtype=dtype)

return labels

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def __new__(cls, data=None, dtype=None, copy=False, name=None,
else:
subarr = com.asarray_tuplesafe(data, dtype=object)

# _asarray_tuplesafe does not always copy underlying data,
# asarray_tuplesafe does not always copy underlying data,
# so need to make sure that this happens
if copy:
subarr = subarr.copy()
Expand Down