Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove grammar duplication in groupby docs #21534

Merged
merged 2 commits into from
Jun 19, 2018
Merged

DOC: remove grammar duplication in groupby docs #21534

merged 2 commits into from
Jun 19, 2018

Conversation

adamjstewart
Copy link
Contributor

"can be could be" -> "could be"

@@ -680,8 +680,7 @@ match the shape of the input array.
data_range = lambda x: x.max() - x.min()
ts.groupby(key).transform(data_range)

Alternatively the built-in methods can be could be used to produce the same
outputs
Alternatively the built-in methods could be used to produce the same outputs.
Copy link
Member

@gfyoung gfyoung Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this chance to improve the docs even further and add a comma after "Alternatively"

@gfyoung gfyoung added this to the 0.24.0 milestone Jun 19, 2018
@gfyoung
Copy link
Member

gfyoung commented Jun 19, 2018

Marking this for 0.24.0, as this is a relatively trivial PR, and we can pick this up and bring to the finish line (I only have one comment, otherwise, LGTM) if it goes stale.

@jorisvandenbossche jorisvandenbossche changed the title Remove grammar duplication in groupby docs DOC: remove grammar duplication in groupby docs Jun 19, 2018
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #21534 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21534      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         153      153              
  Lines       49594    49594              
==========================================
- Hits        45590    45588       -2     
- Misses       4004     4006       +2
Flag Coverage Δ
#multiple 90.32% <ø> (-0.01%) ⬇️
#single 41.82% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.75% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6131a59...e2ae4d1. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jorisvandenbossche jorisvandenbossche merged commit 71c53f0 into pandas-dev:master Jun 19, 2018
@jorisvandenbossche
Copy link
Member

@adamjstewart Thanks!

@adamjstewart adamjstewart deleted the docs/groupby branch June 19, 2018 12:20
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants