Skip to content

BUG: encoding error in to_csv compression #21300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 5, 2018
Merged

BUG: encoding error in to_csv compression #21300

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fdd3ce9
handle encoding type
minggli May 31, 2018
826aa2c
enrich comment
minggli Jun 2, 2018
fac53c0
add encoding fixture
minggli Jun 2, 2018
a4de620
remove redundant import
minggli Jun 2, 2018
b833abd
add encoding fixture
minggli Jun 2, 2018
b625f08
handle PY2 differently
minggli Jun 3, 2018
9d5c25b
restore original test case
minggli Jun 3, 2018
8ed6fa2
update whatsnew
minggli Jun 3, 2018
2d48d10
default bytes strings unless requires unicode string
minggli Jun 3, 2018
4a6f5ff
assert filehandle open
minggli Jun 3, 2018
bf4225c
use buffer and avoid roundtrip and encoding error.
minggli Jun 3, 2018
486f3ff
update whatsnew
minggli Jun 3, 2018
d8435ef
minor refactor of tests
minggli Jun 3, 2018
16cc951
clearer categorisation of input type
minggli Jun 3, 2018
6714e68
more compact if statements
minggli Jun 3, 2018
f73f9ff
documentation
minggli Jun 3, 2018
f891533
add comments on path_or_buf types
minggli Jun 4, 2018
f3c3ea7
remove close
minggli Jun 4, 2018
4e914ff
test file-handle to_csv with compression and encoding
minggli Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update whatsnew
  • Loading branch information
@minggli
minggli committed Jun 3, 2018
commit 8ed6fa2e3c86dc58023db6f0de72ae9a03437329
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.23.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ I/O

- Bug in IO methods specifying ``compression='zip'`` which produced uncompressed zip archives (:issue:`17778`, :issue:`21144`)
- Bug in :meth:`DataFrame.to_stata` which prevented exporting DataFrames to buffers and most file-like objects (:issue:`21041`)
- Bug in :meth:`DataFrame.to_csv` using compression causes encoding error (:issue:`21241`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also mention Series.to_csv here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

-

Plotting
Expand Down