Skip to content

ENH: add in extension dtype registry #21185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 3, 2018
Merged

ENH: add in extension dtype registry #21185

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4b132cf
ENH: add in extension dtype registry
jreback May 13, 2018
90fccb0
review comments
jreback May 24, 2018
80e15fd
remove ops
jreback May 25, 2018
1c3d023
move array_type -> construct_array_type
jreback May 25, 2018
4b05a1c
interval dtypes
jreback May 28, 2018
9cfbc07
doc in construct_array_type
jreback May 28, 2018
72e1010
add repr tests
jreback May 29, 2018
59b3510
make construct_array_type arg optional
jreback May 29, 2018
07d1038
small doc enhancements
jreback Jun 3, 2018
7dbd2f3
review comments
jreback Jun 19, 2018
7a2cb6a
remove arg from construct_array_type as no longer needed
jreback Jun 19, 2018
96d5d09
doc comments
jreback Jun 19, 2018
5119672
lint
jreback Jun 19, 2018
e22d4c7
remove doc note
jreback Jun 19, 2018
7cc1a0a
remove append
jreback Jun 20, 2018
930cec5
remove dropna text
jreback Jun 20, 2018
bd5dcd3
Revert "remove dropna text"
jreback Jun 20, 2018
407d7b3
remove arg from construct_array_type in base class
jreback Jun 21, 2018
9084906
use simpler dtype for intervals
jreback Jun 21, 2018
f560ea1
rebase
jreback Jun 25, 2018
5fabd51
Merge branch 'master' into eat
jreback Jul 2, 2018
d2c91d7
Merge branch 'master' into eat
jreback Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc comments
  • Loading branch information
@jreback
jreback committed Jun 29, 2018
commit 96d5d09df5592d74751a12783d7a9cfb402f0bc1
4 changes: 2 additions & 2 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ ExtensionType Changes

- ``ExtensionArray`` has gained the abstract methods ``.dropna()`` and ``.append()`` (:issue:`21185`)
Copy link
Member

@jorisvandenbossche jorisvandenbossche Jun 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before, I am not convinced we should necessarily add those methods (certainly append), so would personally leave this for another PR to discuss

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with not adding append.

Could go either way on dropna.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need them for subsquent PR's I guess will move them.

- ``ExtensionDtype`` has gained the ability to instantiate from string dtypes, e.g. ``decimal`` would instantiate a registered ``DecimalDtype``; furthermore
the dtype has gained the ``construct_array_type`` (:issue:`21185`)
the ``ExtensionDtype`` has gained the method ``construct_array_type`` (:issue:`21185`)
- The ``ExtensionArray`` constructor, ``_from_sequence`` now take the keyword arg ``copy=False`` (:issue:`21185`)
- :meth:`Series.combine()` works correctly with :class:`~pandas.api.extensions.ExtensionArray` inside of :class:`Series` (:issue:`20825`)
- :meth:`Series.combine()` with scalar argument now works for any function type (:issue:`21248`)
Expand Down Expand Up @@ -164,7 +164,7 @@ Current Behavior:
OverflowError: Trying to coerce negative values to unsigned integers

- :class:`DatetimeIndex` now accepts :class:`Int64Index` arguments as epoch timestamps (:issue:`20997`)
- Invalid consruction of ``IntervalDtype`` will now always raise a ``TypeError`` rather than a ``ValueError`` if the subdtype is invalid (:issue:`21185`)
- Invalid construction of ``IntervalDtype`` will now always raise a ``TypeError`` rather than a ``ValueError`` if the subdtype is invalid (:issue:`21185`)
-
-

Expand Down