Skip to content

BUG: Series.combine() fails with ExtensionArray inside of Series #21183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 8, 2018
Merged

BUG: Series.combine() fails with ExtensionArray inside of Series #21183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7469ca9
BUG: Series.combine() fails with ExtensionArray inside of Series
gfyoung May 23, 2018
bbb6640
Merge remote-tracking branch 'upstream/master' into issue20825
Dr-Irv May 23, 2018
339b23a
Fixes as requested by pandas maintainers
Dr-Irv May 23, 2018
61a09e7
Fix PEP8 issues
Dr-Irv May 23, 2018
d862e83
Merge remote-tracking branch 'upstream/master' into issue20825
Dr-Irv May 24, 2018
4c925fc
get rid of is_sequence_of_dtype
Dr-Irv May 24, 2018
27480ac
move whatsnew from 0.23.1 to 0.24
Dr-Irv May 24, 2018
f96372e
Merge remote-tracking branch 'upstream/master' into issue20825
Dr-Irv May 29, 2018
677fe18
remove binop changes and make it work right with scalar
Dr-Irv May 29, 2018
9fceee7
Move test_combine tests to base class
Dr-Irv May 30, 2018
1010cb5
Fix lint issue
Dr-Irv May 31, 2018
aceea9f
Change NotImplemented to NotImplementedError
Dr-Irv May 31, 2018
79506ac
Merge remote-tracking branch 'upstream/master' into issue20825
Dr-Irv May 31, 2018
0e4720b
put in keyword arg for na_value_for_dtype
Dr-Irv Jun 4, 2018
2a21117
Merge remote-tracking branch 'upstream/master' into issue20825
Dr-Irv Jun 6, 2018
e08f832
Merge branch 'master' of github.com:Dr-Irv/pandas into issue20825
Dr-Irv Jun 6, 2018
d3ed2c7
cosmetic changes. fix test_add for category
Dr-Irv Jun 6, 2018
4ca28b2
Doc changes
Dr-Irv Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move whatsnew from 0.23.1 to 0.24
  • Loading branch information
@Dr-Irv
Dr-Irv committed May 24, 2018
commit 27480ac48df566fb553f44fe16fc8facff27e25e
1 change: 0 additions & 1 deletion doc/source/whatsnew/v0.23.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ Bug Fixes
~~~~~~~~~

- tab completion on :class:`Index` in IPython no longer outputs deprecation warnings (:issue:`21125`)
- :meth:`Series.combine()` no longer fails with :class:`~pandas.api.extensions.ExtensionArray` inside of :class:`Series` (:issue:`20825`)

Groupby/Resample/Rolling
^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ Reshaping
Other
^^^^^

- :meth:`Series.combine()` no longer fails with :class:`~pandas.api.extensions.ExtensionArray` inside of :class:`Series` (:issue:`20825`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be positive. say it works!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

-
-
-
Expand Down