-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Cythonized GroupBy Quantile #20405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cythonized GroupBy Quantile #20405
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
618ec99
Reorganized existing describe test
WillAyd 74871d8
Added quantile tests and impl
WillAyd 7b6ca68
Broken impl and doc updates
WillAyd 31aff03
Working impl with non-missing; more tests
WillAyd 4a43815
DOC: update the Index.isin docstring (#20249)
noemielteto eb18823
Working impl with NA data
WillAyd 813da81
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd e152dd5
Added check_names arg to failing tests
WillAyd 7a8fefb
Added tests for dt, object raises
WillAyd b4938ba
Added interpolation keyword support
WillAyd 3f7d0a9
LINT fix
WillAyd d7aec3f
Updated benchmarks
WillAyd e712946
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 72cd30e
Removed errant git diff
WillAyd a3c4b11
Removed errant pd file
WillAyd ac96526
Fixed broken function tests
WillAyd 7d439d8
Added check_names=False to tests
WillAyd 3047eed
Py27 compat
WillAyd 70bf89a
LINT fixup
WillAyd 02eb336
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 7c3c349
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 3b9c7c4
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd ad8b184
Replaced double with float64
WillAyd b846bc2
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 93b122c
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 09308d4
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 1a718f2
Fixed segfault on all NA group
WillAyd ff062bd
Stylistic and idiomatic test updates
WillAyd bdb5089
LINT fixup
WillAyd 9b55fb5
Added cast to remove build warning
WillAyd 31e66fc
Used memoryview.shape instead of len
WillAyd 41a734f
Use pytest.raises
WillAyd 67e0f00
Better Cython types
WillAyd 07b0c00
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 86aeb4a
Loosened test expectation on Windows
WillAyd 86b9d8d
Used api types
WillAyd cfa1b45
Removed test hacks
WillAyd 00085d0
Used is_object_dtype
WillAyd 1f02532
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 3c64c1f
Removed loosened check on agg_result
WillAyd 09695f5
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 68cfed9
isort fixup
WillAyd 4ce1448
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 5e840da
Removed nonlocal variable usage
WillAyd 7969fb6
Updated documentation
WillAyd f9a8317
LINT fixup
WillAyd 464a831
Reverted errant whatsnew
WillAyd 4b3f9be
Refactor processor signatures
WillAyd b996e1d
Documentation updates
WillAyd cdd8985
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 64f46a3
Added empty assignment for variable
WillAyd 4d88e8a
Docstring fixup
WillAyd 1cd93dd
Updated README
WillAyd 9ae23c1
Pytest arg deprecation fix
WillAyd eb99f07
Removed test_describe test
WillAyd 94d4892
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 0512f37
Moved whatsnew
WillAyd 2370129
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd a018570
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd f41cd05
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 21691bb
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 082aea3
LINT fixup
WillAyd dc5877a
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd 7496a9b
Merge remote-tracking branch 'upstream/master' into grp-desc-perf
WillAyd ec013bf
LINT fixup
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
LINT fix
- Loading branch information
commit 3f7d0a966c016c61e655ede780fa7697155f5d0e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extremely nuanced but I was having trouble figuring out how NumPy would consistently handle the
nearest
tiebreaker when the provided quantile falls directly in between two values.For instance:
It wasn't apparent why the first example above was rounding up and the second was rounding down. I glanced at the NumPy implementation which appears to use
np.around
. In that functions' documentation it saysBut again that doesn't explain the behavior above. I'm wondering if the behavior here would even be well defined across different platforms?