Skip to content

Preliminary format refactor #20341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Mar 14, 2018
Merged

Preliminary format refactor #20341

merged 26 commits into from
Mar 14, 2018

Conversation

@shangyian
Copy link
Contributor

@shangyian shangyian commented Mar 14, 2018

The branch for the other PR was messed up, so I created a new one.

  • based on discussion here: Latex bugs #20032 (review)
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This PR splits the various formatters into different files so that it's easier to refactor a specific formatter.

shangyian and others added 26 commits March 8, 2018 10:58
@shangyian
Separating the formatters into different files
fb79b19
@shangyian
Fixing flake8 issues
d57630d
@shangyian
Changing _put_lines from protected function
d4bcb17
@shangyian
Adding back CSVFormatter to be compatible
dc0778a
@shangyian
Some small changes based on feedback
13ba22f
@shangyian
flake8 fixes
fcfb87a
@shangyian
changing csv import name or else conflicts
7b26f2c
@shangyian
renaming because of naming conflicts otherwise
d6f4c8e
@jreback
Merge branch 'master' into PR_TOOL_MERGE_PR_20051
3afd771
@jreback
clean up imports
f8abfec
@jreback
rename csv -> csvs
196220b
@shangyian
Removing io.formats.common and moving functions to formats.format
6451eb5
@shangyian
Fixing imports
1b4182a
@shangyian
Separating the formatters into different files
8e5fdec
@shangyian
Fixing flake8 issues
e114ba9
@shangyian
Changing _put_lines from protected function
b3e5ff4
@shangyian
Adding back CSVFormatter to be compatible
832d26e
@shangyian
Some small changes based on feedback
45f6aac
@shangyian
flake8 fixes
fae177b
@shangyian
changing csv import name or else conflicts
2cd9648
@shangyian
renaming because of naming conflicts otherwise
691aa6c
@jreback @shangyian
clean up imports
28b66dc
@jreback @shangyian
rename csv -> csvs
764533c
@shangyian
Removing io.formats.common and moving functions to formats.format
719b02c
@shangyian
Fixing imports
de39e22
@shangyian
Merge branch 'prelim_format_refactor' of github.com:shangyian/pandas …
c9b4504 
…into prelim_format_refactor
@jreback jreback added Refactor Internal refactoring of code IO CSV read_csv, to_csv IO HTML read_html, to_html, Styler.apply, Styler.applymap IO LaTeX to_latex labels Mar 14, 2018
@jreback jreback added this to the 0.23.0 milestone Mar 14, 2018
@jreback
Copy link
Contributor

jreback commented Mar 14, 2018

lgtm. ping on green.

@jreback jreback merged commit cad6dc7 into pandas-dev:master Mar 14, 2018
@jreback
Copy link
Contributor

jreback commented Mar 14, 2018

thanks @shangyian

@jakirkham jakirkham mentioned this pull request Jul 22, 2018
Closed
@dhimmel dhimmel mentioned this pull request Jul 26, 2018
Merged
4 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 16, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IO CSV read_csv, to_csv IO HTML read_html, to_html, Styler.apply, Styler.applymap IO LaTeX to_latex Refactor Internal refactoring of code

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shangyian @jreback