DOC: update the Seriex.idxmax and Series.idxmin docstring #20174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/frame.py
Outdated
| def drop(self, labels=None, axis=0, index=None, columns=None, | ||
| level=None, inplace=False, errors='raise'): | ||
| """ | ||
| Drop rows or columns. |
There was a problem hiding this comment.
Would like this to mention how the rows are determined. Maybe Drop specified labels from rows or columns.
There was a problem hiding this comment.
some leftovers from the other PR here. But you can give the comment on #20120
pandas/core/frame.py
Outdated
| ---------- | ||
| labels : single label or list-like | ||
| Index or column labels to drop. | ||
| axis : int or axis name, default 0 |
There was a problem hiding this comment.
axis : {0 or 'index', 1 or 'columns'}, default 0
JennaVergeynst
force-pushed
the
DOC_series_idxmax
branch
from
0d3378d to
eb7fd74
Compare
Codecov Report
@@ Coverage Diff @@
## master #20174 +/- ##
=========================================
Coverage ? 91.7%
=========================================
Files ? 150
Lines ? 49156
Branches ? 0
=========================================
Hits ? 45078
Misses ? 4078
Partials ? 0
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>git diff upstream/master -u -- "*.py" | flake8 --diffpython doc/make.py --single <your-function-or-method>Please include the output of the validation script below between the "```" ticks:
Parameters args and kwargs don't need types, put them on one line to keep it concise.