Skip to content

implement Timedelta mod, divmod, rmod, rdivmod, fix and test scalar methods #19365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

implement Timedelta mod, divmod, rmod, rdivmod, fix and test scalar methods #19365

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4688064
implement mod, divmod, rmod, rdivmod, fix and test scalar methods
jbrockmendel Jan 24, 2018
baf4d6b
whatsnew, gh reference in tests
jbrockmendel Jan 24, 2018
a2b1ac7
separate tests for invalid mod and divmod
jbrockmendel Jan 25, 2018
8224871
docs
jbrockmendel Jan 25, 2018
9558dc9
fix test broken on appveyor
jbrockmendel Jan 25, 2018
f838cc9
requested edits
jbrockmendel Jan 29, 2018
cd421db
Merge branch 'master' of https://github.com/pandas-dev/pandas into tdmod
jbrockmendel Jan 29, 2018
ed99f50
Merge branch 'master' of https://github.com/pandas-dev/pandas into tdmod
jbrockmendel Feb 6, 2018
1ace838
de-dup tests, edit whatsnew
jbrockmendel Feb 9, 2018
0de3bd4
Merge branch 'master' of https://github.com/pandas-dev/pandas into tdmod
jbrockmendel Feb 12, 2018
acff328
implement suggested changes to catching zero-dim numpy objs
jbrockmendel Feb 12, 2018
73fd6dc
Delay int/float cases
jbrockmendel Feb 13, 2018
4cbb2e1
revert edit that broke floordiv
jbrockmendel Feb 13, 2018
08fa8fd
pass on is_timedelta64_object
jbrockmendel Feb 15, 2018
03b7e17
catch late-NaT
jbrockmendel Feb 15, 2018
120d61f
Merge branch 'master' of https://github.com/pandas-dev/pandas into tdmod
jbrockmendel Feb 16, 2018
c1fbdc9
requested edits to docs
jbrockmendel Feb 17, 2018
b2995c9
revert zero-dim de-specialization
jbrockmendel Feb 17, 2018
c22dc47
dummy commit to force CI
jbrockmendel Feb 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dummy commit to force CI
  • Loading branch information
@jbrockmendel
jbrockmendel committed Feb 17, 2018
commit c22dc473e0473a5f93c9e3bc97d5b19c4ea268ea
1 change: 1 addition & 0 deletions pandas/_libs/tslibs/timedeltas.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,6 +1191,7 @@ class Timedelta(_Timedelta):
return div, self - div * other

def __rdivmod__(self, other):
# Naive implementation, room for optimization
div = other // self
return div, other - div * self

Expand Down