Skip to content

ENH: Added public accessor registrar #18827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jan 16, 2018
Merged

ENH: Added public accessor registrar #18827

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
6ae52d4
ENH: Added public accessor registrar
TomAugspurger Dec 8, 2017
998bb28
PEP8
TomAugspurger Dec 18, 2017
9b20a5c
Moved to extensions
TomAugspurger Dec 19, 2017
9005e1c
More docs
TomAugspurger Dec 19, 2017
33a9f3f
Fix see also
TomAugspurger Dec 19, 2017
27c6af0
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Dec 20, 2017
35db58d
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Jan 2, 2018
11edc42
DOC: Added whatsnew
TomAugspurger Jan 2, 2018
682bb84
Move to api
TomAugspurger Jan 2, 2018
964356f
Update post review
TomAugspurger Jan 2, 2018
ec505e4
flake8
TomAugspurger Jan 2, 2018
e76cecf
Raise the underlying error instead of a RuntimeError
TomAugspurger Jan 2, 2018
19e9fa0
str validate
TomAugspurger Jan 4, 2018
c1c498c
DOC: Moved to developer
TomAugspurger Jan 4, 2018
ecc1cd7
REF: Use public registrars for accessors
TomAugspurger Jan 4, 2018
663542e
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Jan 4, 2018
2ad2fa0
cleanup
TomAugspurger Jan 4, 2018
402f08c
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Jan 4, 2018
c2a94e8
Implemented optional caching
TomAugspurger Jan 4, 2018
d910a0f
Document cache
TomAugspurger Jan 4, 2018
8bcd412
Tests passing
TomAugspurger Jan 4, 2018
ded3513
Use for plot
TomAugspurger Jan 4, 2018
632f097
Fix autodoc
TomAugspurger Jan 4, 2018
5dc4d05
Fix the class instantiation
TomAugspurger Jan 4, 2018
28865d7
Refactor again.
TomAugspurger Jan 4, 2018
3bf4889
Fix API files
TomAugspurger Jan 4, 2018
dea5d17
Remove stale comment
TomAugspurger Jan 4, 2018
9559f12
Tests pass
TomAugspurger Jan 5, 2018
b00b0f8
DOC: some cleanup
TomAugspurger Jan 5, 2018
f03777f
No need to assign doc
TomAugspurger Jan 5, 2018
1bedf9f
Rename, shared docs
TomAugspurger Jan 5, 2018
018facd
Doc __new__
TomAugspurger Jan 5, 2018
a308a2e
Use UserWarning
TomAugspurger Jan 10, 2018
66e2207
Update test
TomAugspurger Jan 10, 2018
1c75879
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Jan 12, 2018
fd40244
Merge remote-tracking branch 'upstream/master' into accessor-decorator
TomAugspurger Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove stale comment
  • Loading branch information
@TomAugspurger
TomAugspurger committed Jan 4, 2018
commit dea5d173a3406f09edfa1ebd9905f16d126bd0ac
1 change: 0 additions & 1 deletion pandas/core/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ def f(self, *args, **kwargs):
# Ported with modifications from xarray
# https://github.com/pydata/xarray/blob/master/xarray/core/extensions.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, please do let me know exactly what you needed to change :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the relevant diff between xarray and pandas:

@TomAugspurger : For better or worse, that's a much less significant change than I expected. Maybe should add a comment about that.

# 1. We don't need to catch and re-raise AttributeErrors as RuntimeErrors
# 2. We made caching configurable


class _CachedAccssor(object):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name this: CachedAccessor we use this internally so private is not appropriate

Expand Down