-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Prevent passing invalid kwds to DateOffset constructors #18226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 35 commits into
pandas-dev:master
from
jbrockmendel:tslibs-offsets-inits
Nov 25, 2017
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b9fe60e
Patch __init__ to prevent passing invalid kwds
jbrockmendel f10a1c6
cast n to integer, assert equality
jbrockmendel 807d769
whatsnew note
jbrockmendel 687e3b7
parameterize tests, define fixture where it is used
jbrockmendel d5443ca
fixup
jbrockmendel 5e5e0c0
exclude base classes from testing
jbrockmendel 17f7b5a
exclude base classes from testing
jbrockmendel 3834ef8
dummy commit to force CI
jbrockmendel 1c54e96
edits per reviewer suggestions
jbrockmendel 0e37a24
whatsnew whitespace
jbrockmendel a572368
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel d0ff381
whitespace fixup
jbrockmendel 409dbd0
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel 6a9233e
break up hour test to debug appveyor error (segfault?)
jbrockmendel 4406df8
break down segfaulting test to debug
jbrockmendel 44891cd
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel 573abb6
fixturize
jbrockmendel c6cc8bc
troubleshoot segfault by moving __eq__ to _BaseOffset
jbrockmendel a68f4a7
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel c8224c1
try sorting rd_kwds to fix segfault, revert other troubleshooting gue…
jbrockmendel 55779d8
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel d5b8302
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel b54e26b
implement _validate_n method
jbrockmendel fade4a2
test for _validate_n
jbrockmendel 38c2238
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel fe895ff
Raise TypeError, not ValueError
jbrockmendel 11ba1a9
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel bc90a19
Catch ValueError in int(n)
jbrockmendel 0b3dca0
fixup extra imports
jbrockmendel 9c841fc
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel adee395
remove unnecessary re-definitions, add tests, improve error msg
jbrockmendel 43dc17e
Add docstring to validate_n
jbrockmendel 4ff8c22
fixup missing format
jbrockmendel d261be9
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel b4b9e15
Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
break up hour test to debug appveyor error (segfault?)
- Loading branch information
commit 6a9233ecebd0741400d6d61fda4fb91dd77112eb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if you need to move
__eq__
to_BaseOffset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For lack of any better ideas, let's give it a shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If somehow this does fix the error, pls don't merge it just yet. I'm trying to avoid moving methods to the cython classes until I've vetted them, and
__eq__
is very much not OK.