Remove unused cimports #17585
Remove unused cimports #17585
Conversation
gfyoung
added
Clean
Internals
|
you are doing quite a lot of things here. specifically don't include the property changes here. |
|
properties separated out into #17590 |
Codecov Report
@@ Coverage Diff @@
## master #17585 +/- ##
==========================================
+ Coverage 91.19% 91.2% +<.01%
==========================================
Files 163 163
Lines 49626 49625 -1
==========================================
+ Hits 45258 45261 +3
+ Misses 4368 4364 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17585 +/- ##
==========================================
+ Coverage 91.19% 91.2% +<.01%
==========================================
Files 163 163
Lines 49652 49652
==========================================
+ Hits 45282 45285 +3
+ Misses 4370 4367 -3
Continue to review full report at Codecov.
|
pandas/_libs/lib.pyx
Outdated
| @@ -67,6 +67,7 @@ import tslib | |||
| from tslib import NaT, Timestamp, Timedelta | |||
| import interval | |||
| from interval import Interval | |||
| from properties import AxisProperty, cache_readonly | |||
There was a problem hiding this comment.
are you adding these back for a reason?
There was a problem hiding this comment.
Looks like a rebase screwup. Will fix.
|
|
||
| cdef int64_t us_in_day = conversion_factor(r_microsecond, r_day) | ||
|
|
||
| cdef class _Offset: |
There was a problem hiding this comment.
anything useful from this file?
There was a problem hiding this comment.
I looked through it and didn't find anything worth keeping. I've got a cython version of tseries.offsets in a branch that is a few PRs away from being ready to push upstream.
setup.py
Outdated
| @@ -476,6 +476,7 @@ def pxd(name): | |||
| libraries = ['m'] if not is_platform_windows() else [] | |||
|
|
|||
| ext_data = { | |||
| '_libs.properties': {'pyxfile': '_libs/properties', 'include': []}, | |||
|
thanks! |
This helps a little bit with the complexity of the libs interdependencies.
Make properties.pyx its own module, since we will end up needing it to be separate when
tseries.offsetsgets moved into cython.Remove the long-defunct _libs/src/offsets.pyx.
git diff upstream/master -u -- "*.py" | flake8 --diff