Lock down kwargs in offsets signatures #17458
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -328,6 +328,13 @@ Previously, :func:`to_datetime` did not localize datetime ``Series`` data when ` | |
|
|
||
| Additionally, DataFrames with datetime columns that were parsed by :func:`read_sql_table` and :func:`read_sql_query` will also be localized to UTC only if the original SQL columns were timezone aware datetime columns. | ||
|
|
||
| .. _whatsnew_0210.api.restricting_dateoffset_keywords | ||
|
|
||
| Restricting DateOffset Keywords | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Previously, ``DateOffset`` subclasses allowed arbitrary keyword arguments which could lead to unexpected behavior. Now, subclasses :class:`Week`, :class:`WeekOfMonth`, :class:`LastWeekOfMonth`, :class:`QuarterOffset`, :class:`QuarterEnd`, :class:`QuarterBegin`, :class:`BQuarterEnd`, and :class:`BQuarterBegin`, will allow only specific arguments. (:issue:`17176`). | ||
|
There was a problem hiding this comment. aren't Month/MonthEnd included here? why not all classes? There was a problem hiding this comment.
Not as of now, no.
Wanted to change them a couple at a time, err on the side of doing too little. Now that #17486 is resolved I can push forward on a few more. You want to just get them all in one go? There was a problem hiding this comment. yes for this type of change am ok with doing it in one fell swoop. On the whatsnew just highlite the change generally (e.g. give a single example), then list the classes that are affected (or if its all, then just say all). imagine a user who just 'uses' pandas. They want to quickly get to: does this change affect me, if so, what do I need to do to fix. |
||
|
|
||
| .. _whatsnew_0210.api: | ||
|
|
||
| Other API Changes | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, since we made this simpler, move to just a bullet point in Other API changes section.