Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports from period.pyx #17434

Closed
wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

Replace isinstance checks with more efficient versions from util;

Remove redundant checks for isinstance(..., (timedelta, Timedelta)) since
Timedelta subclasses timedelta

The main goal is to reduce the inter-dependencies between lib/tslib/period(/frequencies/offsets).

Replace isinstance checks with more efficient versions from util;

Remove redundant checks for isinstance(..., (timedelta, Timedelta)) since
Timedelta subclasses timedelta
@sinhrks sinhrks added Clean Internals Related to non-user accessible pandas implementation Period Period data type labels Sep 5, 2017
@jreback
Copy link
Contributor

jreback commented Sep 5, 2017

an asv run for period benchmarks is useful for proving claims here. a simple posted timeit on performance claim is also useful to the causal reader.

@jbrockmendel
Copy link
Member Author

I've been instructed to use the util versions wherever possible.

No idea what the Travis error means, so am inclined to drop it. This for now. asv will be easier if/when #17331 is merged.

@jbrockmendel jbrockmendel deleted the inde_period branch October 30, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants