Skip to content

Unify Index._dir_* with Series implementation #17117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 29, 2017
Merged

Unify Index._dir_* with Series implementation #17117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9d1f05
Make Index behave more like Series
jbrockmendel Jul 29, 2017
b980958
flake8 cleanups
jbrockmendel Jul 29, 2017
f43d247
Fix lint unused import
jbrockmendel Jul 30, 2017
dbfc115
Merge branch 'master' of https://github.com/pandas-dev/pandas into in…
jbrockmendel Aug 9, 2017
2a6afcb
Rebase, move DirNamesMixin to accessor.py
jbrockmendel Aug 9, 2017
7aa973e
Flake8 whitespace fixup
jbrockmendel Aug 9, 2017
d71dbf8
Remove shebang, add docstring per review request
jbrockmendel Aug 16, 2017
a213927
flake8 whitespace fixup
jbrockmendel Aug 19, 2017
bf66c5b
Fixes for reviewer comments
jbrockmendel Aug 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Flake8 whitespace fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Aug 9, 2017
commit 7aa973e0fb953b8a6ecefcde26912f1526ba2aca
1 change: 1 addition & 0 deletions pandas/core/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the first line, we don't normally do this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a commit that does this and adds a comment in the docstring as requested below. The docstring isn't super-useful at this point because there isn't much here. After this is merged I'll rebase #17042 and accessor.py will have a coherent theme.

# -*- coding: utf-8 -*-

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment about what this module contains


class DirNamesMixin(object):
_accessors = frozenset([])

Expand Down
3 changes: 0 additions & 3 deletions pandas/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ def __repr__(self):
return str(self)





class PandasObject(StringMixin, DirNamesMixin):

"""baseclass for various pandas objects"""
Expand Down