PERF: correctly report memory used by Index's #15237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
jreback
commented
Jan 26, 2017
| @@ -237,6 +238,12 @@ cdef class {{name}}HashTable(HashTable): | |||
| k = kh_get_{{dtype}}(self.table, key) | |||
| return k != self.table.n_buckets | |||
|
|
|||
| def sizeof(self, deep=False): | |||
| """ return the size of my table in bytes """ | |||
| return self.table.n_buckets * (sizeof(self.table.keys) + | |||
There was a problem hiding this comment.
@wesm I believe this is correctly, any thoughts?
There was a problem hiding this comment.
sizeof will return a pointer size here - I think you instead need to do something like this? (not sure the kh aliases are exposed)
self.table.n_buckets * (sizeof(khkey_t) + #keys
sizeof({{dtype}}_t) + #vals
sizeof(khint32_t)) #flags
pandas/pandas/src/klib/khash.h
Line 189 in be32852
Current coverage is 86.31% (diff: 100%)@@ master #15237 diff @@
==========================================
Files 139 139
Lines 51096 51103 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44103 44110 +7
Misses 6993 6993
Partials 0 0
|
|
What do you think about using |
|
@MaximilianR I added
|
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Author: Jeff Reback <jeff@reback.net> Closes pandas-dev#15237 from jreback/memory and squashes the following commits: d77c002 [Jeff Reback] PERF: correctly report memory used by Index's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.